Repository navigation
fix(markdown): preserve wrapped HTTP link destinations - #1114
Merged
Merged
Conversation
Normalize nested linked-host HTTP(S) destinations before rehype sanitation so transcript anchors retain a usable href and existing click and context-menu actions stay reachable. Add parser and production-render regressions and update E2E-196.
Exercise the production Markdown renderer in Chromium so wrapped links prove their destination, plain-click route, and pointer context-menu actions. Record the partial E2E coverage while leaving unrelated settings and keyboard journeys marked Draft.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
pnpm build:jspnpm --filter @pi-desktop/desktop typechecknode --test --test-concurrency=1 apps/desktop/test/*.test.mjs— 2,957 passedpnpm test:e2e:transcript— passed, including wrapped-link href, click route, and context-menu optionspnpm check:pr-base— passedSettings persistence, browser-action activation, and keyboard menu navigation remain outside this targeted regression and are still marked Draft in E2E-196.