Repository navigation
fix(desktop): portal route dialogs above the sidebar - #1119
Merged
Merged
Conversation
Route-owned modal surfaces could be trapped in the page stacking context, leaving the expanded sidebar above their backdrop and controls. Mount the plugin and release-note surfaces on the viewport overlay host and keep portaled plugin layers interactive. Extend the overlay regression coverage and document the viewport-level contract for the affected plugin flows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n\n- Mount plugin detail, settings, permission, template, install-progress, and release-note dialogs on the viewport overlay host.\n- Keep portaled plugin modal and sheet layers interactive through the shared pointer-events host.\n- Add regression coverage and update the UX/E2E contracts.\n\n## Validation\n\n- Overlay/style regression tests: 38 passed.\n- Related update/project/session tests: 25 passed.\n- Desktop style-token lint: passed.\n- Typecheck: blocked by pre-existing optional voice dependencies missing from the host environment: opencc-js, @huggingface/hub, transcribe-cpp, and @picovoice/pvrecorder-node.\n- Desktop UI E2E: not run; renderer build output is unavailable and the repository requires explicit authorization for UI verification scripts.