fix(permissions): remove local approval deadline - #1218
Merged
Merged
Conversation
Keep local tool approvals pending until an explicit decision or cancellation. Remove renderer countdown and timeout fields while preserving tool execution budgets and remote/Plan approval lifetimes. fixes #1214
Update the desktop source contract test for the removal of the local permission transport deadline. Keep the Bash execution budget assertion while allowing the approval wait to remain open. fixes #1214
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1214
Validation
Known limitation: full desktop build/typecheck remains blocked by existing opencc-js/live-voice dependency issues.