Repository navigation
fix(models): match relay IDs to official metadata - #1262
Merged
Merged
Conversation
Resolve unidentified relay models from an exact route leaf and prefer the published record for their owning ID family. Fall back only for whitelisted deployment/context suffixes while preserving the served ID and stored limit pins. Add relay matching and binding regression coverage, and document the conservative suffix rules.
Electron Main is emitted as an ES module, so Node does not provide the CommonJS __dirname global used for preload and asset paths. Define it from import.meta.dirname in the main bundle to keep Electron booting under the production module format. Add a build-contract regression test for the ESM path mapping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-testand-1m; preserve the served wire ID and user-pinned limits.__dirnamefor the ESM Electron main bundle so the required boot E2E runs.Validation