Repository navigation
fix(desktop): resolve ask cards through the Host input path - #1293
Merged
vastsa merged 2 commits intoOct 2, 2026
Merged
Conversation
Composer ask confirmations went straight to the sidecar, leaving the Host-owned pending input behind. Switching windows back to the session re-read it via pendingInteractiveRequests and resurrected the already answered card. askToolResolve now settles the matching Host input first (clearing it before the sidecar resolves) and keeps the direct sidecar resolve only as a fallback for unknown requests.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
确认过的提问卡片切窗口回来又冒出来:Composer 确认走了直连 sidecar 通道(askToolResolve → asktool.resolve),Host 那份 pendingInputs 没清;切回会话时 restorePendingInteractive 又把它读回来重建卡片。
改动(3 个文件,纯 fix):
验证: