Repository navigation
fix(updater): stop dismissed releases from downloading - #1339
Merged
Merged
Conversation
The update banner's dismiss button only wrote component-local state, so every restart brought the same notice back for a version the user had already declined. Record the dismissed version through a new `updatesDismiss` IPC channel into host settings (`updateDismissedVersion`), surface it as a `dismissed` flag on UpdateState, and clear it when a newer version is discovered so future releases keep notifying. Validated: update-preference tests 6/6, auto-update tests 8/8, desktop typecheck clean, cargo fmt --check clean. host-core test run requires a Rust toolchain and is left to CI. Fixes #1317
Persist dismissals and cancel active in-app downloads so the same release cannot restart or install on quit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This carries the original dismissal persistence from #1332 forward and completes the in-app behavior. Dismissing an update now stops an active download, prevents the same release from restarting automatically, and permits a later release to resume automatic delivery.
The original contributor commit is retained in this maintainer follow-up.
Related: #1317, #1332.
Validation
node --test apps/desktop/test/updater-controller.test.mjs apps/desktop/test/auto-update.test.mjs apps/desktop/test/update-preference.test.mjs apps/desktop/test/update-timeout.test.mjs— 17 passed.pnpm check:pr-baseequivalent script — passed against662cfcc773ea.git diff --check— passed.