Repository navigation
fix(settings): show the Jev card only once Jev has been added - #1458
Merged
Merged
Conversation
The Jev card sat on the model configuration page of every install, offering "Add key" to users who had never added TypeSafe Jev at all. Jev is one of the services "Add service" provides, so an install without it now has nothing on that page: the card appears once a key is stored, and it leaves again when the key is removed, after the switch that removal already turned off. Two states keep the card: a Host that cannot answer the secret lookup, and an enabled setting that contradicts a missing key. Hiding a configured install would be the worse failure. The status read stays with the card, so the dialog's report of a stored key is what makes the card appear; the card-visibility test covers both directions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Jev card no longer appears on the model configuration page until Jev has
actually been added.
Jev. Adding stays where every other service is added: Add service →
Classifiers.
Agent-mode switch, and the replace/remove actions.
and the card leaves with it.
enabled setting contradicts a missing key — hiding a configured install would
be the worse failure.
Files
apps/desktop/src/components/settings/JevSettingsCard.tsx— the visibilityrule (the status read stays with the card, so the dialog's report of a stored
key is what makes the card appear)
apps/desktop/test/jev-settings-user-path.test.mjs— card path: nothingbefore adding, card + actions after, disabled-then-deleted on removal, card
gone
apps/desktop/test/jev-service-setup-user-path.test.mjs— add path: no cardbefore, card appears after Check and save (asserted with the dialog opened
the way the chooser opens it)
docs/spec/04-ux/06-settings-ia.md,docs/spec/06-delivery/04-e2e-test-plan.mdVerification
tsc -p apps/desktop/tsconfig.json --noEmit: cleanbiome lint,check-style-tokens.mjs,check-architecture.mjs: cleannode --test apps/desktop/test/jev-*.test.mjs: 15/15, including bothisolated-Electron user paths
check:pr-base: head contains currentorigin/main