Repository navigation
feat(desktop): user-configurable close-to-tray with first-close prompt - #3
Merged
Merged
Conversation
|
@Tioit-Wang is attempting to deploy a commit to the vastsa's projects Team on Vercel. A member of the Team first needs to authorize it. |
Avoids collision with the released corner-hierarchy ADR 0071. Updates the title and all references (D210, interaction patterns, E2E plan).
Remove the duplicate @pi-desktop/i18n import and the duplicated tray teardown inside the before-quit shutdown IIFE, drop stray blank lines in tray menu builders, restore the ExtensionMarketSection SettingsCard tail, and re-add the closing brace after the prompt keys in both i18n locales.
vastsa
force-pushed
the
feat/close-to-tray-prompt-once
branch
from
August 15, 2026 07:02
c870aea to
0a1a177
Compare
This was referenced Sep 13, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the Windows/Linux close behavior user-configurable with close-to-tray support (ADR 0071, D210):
closeBehavior/setrejectsask).Implementation
Traycreated lazily and reconciled with the preference;closeis intercepted only forask/traywhilequittingand macOS closes always fall through.<data>/close-behavior.json(no host-core/Rust changes).pi-desktop/window/closeBehavior/getand/set; localized via@pi-desktop/i18n(en + zh-CN).Validation
@pi-desktop/desktoptypecheck passesDocs