Repository navigation
fix(session): keep history when tool ids collide across sessions - #560
Merged
Merged
Conversation
Provider toolCallIds were used as globally unique messages.id. A
collision failed SQLite after the JSONL write, paused the FIFO
persistence outbox, and dropped later assistant/tool rows after quit.
Remap a colliding id to {sessionId}:{id} before the transcript write,
and treat UNIQUE constraint failed: messages.id as an outbox ack so
one poison entry cannot stall every later session.
Fixes #523
A failed UNIQUE append already wrote the original id to JSONL. Replaying it must not append a remapped second line. Orphan restore remaps colliding ids before rebuilding the index so D318 cannot UNIQUE-fail and stall the outbox.
veyliss
pushed a commit
to veyliss/PI-Desktop
that referenced
this pull request
Sep 18, 2026
PR vastsa#550 rewrote the accepted D409 row and the ADR 0239 decision text in place. The log is append-only for accepted decisions, so restore both and record the change as D446 with an ADR 0239 amendment section, marking D409 and the ADR index row as amended. D444 and D445 were taken by PR vastsa#560 and PR vastsa#563 while this branch was in review. Align spec 02-agent-runtime §5e and the error-code table with the narrowed contract (first reply only, tool batch and steering revoke it, provider retry keeps it, accepted silence stays out of model context), add the session-completion suite to the E2E routing index, and mirror every change in the zh-CN pages.
This was referenced Sep 19, 2026
Closed
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #523: closing and reopening dropped later conversation turns.
Provider
toolCallIds (e.g.call_421522) were used as globally uniquemessages.id. A cross-session collision failed SQLite after the JSONL write, paused the FIFO persistence outbox, and later assistant/tool rows from every session never landed.{sessionId}:{id}before writing JSONLUNIQUE constraint failed: messages.idas an ack and keeps drainingTest
cargo test -p host-core append_message_cargo test -p host-core orphanednode --test apps/desktop/test/persistence-outbox.test.mjs