fix(plugins): preserve declared thinkingLevels on plugin providers - #796
Merged
vastsa merged 3 commits intoSep 21, 2026
Merged
Conversation
Owner
|
Verified and merged. The reported bug was real: before this change, PR #796 preserves Landed as merge commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Plugin-declared providers (
contributes.providers) reach the model picker with an empty thinking-level menu even when the manifest declaresthinkingLevels/defaultThinkingLevel. The same models added by hand in Settings keep their levels.Root cause in
crates/host-core/src/plugins/providers.rsdeclared_providers():ModelBindingis built withthinking_levels: Vec::new()anddefault_thinking_level: None— the manifest fields are never read.packages/plugin-sdk/src/index.tsalso omitted the fields fromPluginProviderModelContrib.Solution
thinkingLevels/defaultThinkingLevelthroughnormalize_thinking_levels(same helper the runtime already uses).PluginProviderModelContrib.Addresses the reporter analysis and attached patch on #777 (no separate maintainer design note on the issue).
Testing
cargo testblocked: MSVClink.exenot installed):py -3.13 offline_test_plugin_thinking_levels.py(work tree)offline_plugin_thinking_levels: 5 passedproviders.rs/ SDK / tests.cargo test -p host-core plugins::providersdeclared_thinking_levels_survive_into_the_rowdeclared_thinking_levels_are_normalizeda_default_outside_the_declared_list_is_droppeda_malformed_thinking_levels_field_is_ignoredAgent dimension
tool-retrieval (plugin-declared provider/model catalog reaches the model picker)
Core value
Plugin-contributed models keep their declared reasoning levels instead of a silently empty menu.
Issue alignment
Fixes #777