Skip to content

fix(scheduled): preserve manual task workspace bindings - #803

Merged
vastsa merged 2 commits into
vastsa:mainfrom
yuxino:codex/fix-manual-task-workspace
Sep 21, 2026
Merged

vastsa merged 2 commits into
vastsa:mainfrom
yuxino:codex/fix-manual-task-workspace

Conversation

@yuxino

@yuxino yuxino commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

A Manual task created in project A runs in project B if you switch to B before clicking Run now. Editing the task's title can also change its saved project to B.

The fix keeps the task in its original project when running or editing it, even after restarting the app. Tasks created without a project stay that way, and legacy tasks keep their existing behavior.

Before the fix — actual desktop recording with step labels and highlighted results (2624 × 1824, 2× speed; final result at normal speed):

pr803-desktop-annotated-fast-hd.mp4

Regression tests reproduce the original failure and pass with the fix. They cover running and editing tasks after switching projects, including restart and no-project cases.

Validation details
  • Rust tests: 564 passed; dispatch tests: 6 passed; targeted E2E: 4 scenarios passed.
  • Formatting and Clippy passed, with one existing warning in user_skills.rs:921.
  • Targeted E2E uses the real host and dispatch service with inference stubbed. Full desktop E2E was not rerun.
  • Tested on macOS arm64, Node 24, Rust debug build. Head: 52ad7affb0a5; base: 43a3737352b65. The PR merge candidate has the same tested tree.

yuxino and others added 2 commits September 21, 2026 20:35
Distinguish a saved workspace, including an explicit null binding, from a
legacy task without one. Manual runs and editor updates must not retarget
the task when the foreground project changes.

Cover project and temporary bindings across restart, dispatch and edits,
while retaining legacy fallback behavior.
@vastsa
vastsa merged commit a0bfd87 into vastsa:main Sep 21, 2026
4 checks passed
vastsa added a commit to yuxino/PI-Desktop that referenced this pull request Sep 21, 2026
Resolve the E2E documentation overlap after PR vastsa#803 landed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants