Repository navigation
fix(browser): update chrome after same-document navigation - #811
Merged
Merged
Conversation
Fragment and History API navigation does not emit will-navigate, so the browser kept its previous URL and loading state. Accept current main-frame in-page events while preserving invalidated-session and stale-event guards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clicking an in-page link in the Browser panel scrolls to the right section, but leaves the address bar on the previous URL and the refresh action stuck on Stop. History API route changes also leave the toolbar stale.
Same-document navigation does not emit
will-navigate. This change accepts the active main frame's current in-page URL while retaining the existing session invalidation and stale-navigation guards. The address and history controls now follow the page, and loading returns to Reload.browser-before-after-hd.mp4
Real PI-Desktop before/after recording on macOS with a local test webpage; no mocked navigation. Operations are accelerated and idle time shortened.
Validation: regression cases fail before the fix and pass after it; 26 browser tests, desktop typecheck, lint, JS build, and bilingual documentation checks pass. Native app checks cover fragment links, History API routes, Back, Forward, and Reload. Updated the paired component specification and E2E scenario.
Candidate validation
590fc7b0cbac(full SHA recorded by the PR).0111e306c120ad5820688d7608cb37bad8fbcc1f.E2E-BROWSER-in-page-navigation, manual native-app user path passed on the built candidate. Existing session-race service tests also pass; no fresh race recording is claimed.