Repository navigation
fix(settings): release explicitly deselected image models - #833
Merged
Merged
Conversation
Saving an unchecked image model kept its runnable default binding, so the model stayed excluded from chat choices even with no candidates. Clear that binding before choosing a remaining runnable default, while preserving defaults when other providers are saved. fixes vastsa#826
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unchecking Set as image model and saving still kept the old image default when its provider could run it. With only one model, that left the chat default unavailable even after reopening settings.
Clear the active binding when it is explicitly deselected, then choose a remaining runnable image candidate or leave the image default empty. Saving another provider still preserves the existing default. No settings schema or IPC changes.
The same real desktop steps reproduce the problem before the fix and restore chat selection afterward. This is a 1920×1080 screenshot sequence, not continuous video; waits are omitted. Captured on macOS with an isolated Host database and a local model-list fixture, without live model requests. Windows package verification was not performed.
Fixes #826.
Validation and scope
087d0eff4dcb2cd701f306f1438fc9640e5c751b.206085c07697771f857cab0421bc145e3af41e1d.4fa75ffedf8c76d8c170c32d1ffe90e2e0f21325; its tree exactly matches the tested head (ad6d34cb44677ca0417d689e57247e191ecb1129).node --test apps/desktop/test/image-generation-default.test.mjs apps/desktop/test/default-model-display.test.mjs apps/desktop/test/default-model-picker.test.mjs.node scripts/e2e-image-generation-ui.mjs: English/Chinese cancel, save, reopen and chat selection passed using real components with an API fixture.pnpm build:js, Desktop typecheck,pnpm lint,pnpm docs:check, architecture check,pnpm check:pr-base, andgit diff --checkpassed.Continuous desktop recording
The following 17-second video continuously records the real desktop window at normal speed: uncheck Set as image model, save the provider, reload settings, and select the released model as the chat default. Only trailing idle footage is trimmed; English step labels and outlines identify the relevant controls. This is a native window recording, separate from the screenshot sequence above.
issue-826-continuous.mp4
Recorded on macOS arm64 from merged head
087d0eff4dcb2cd701f306f1438fc9640e5c751b, with an isolated profile/database, real preload and Host persistence, and a local model-list fixture. No paid model requests or personal data. The Host was rebuilt from that candidate and copied to a dedicated binary (SHA-256e47f1bf2d7b44211e4b13a071009db55d2252aebecbdb38ed34545cbf303270c). Native source: 2624×1824; annotated delivery: 1920×1440, 30 fps. Windows package verification remains unperformed.