Repository navigation
feat(config-sync): support LAN HTTP and append-only WebDAV - #838
Merged
Merged
Conversation
Allow users to explicitly acknowledge trusted LAN HTTP endpoints while keeping public HTTP and non-CAS WebDAV servers blocked. Record endpoint-specific 502 missing-object behavior after a capability probe so compatible gateways can initialize safely.
Support WebDAV endpoints that ignore conditional-write headers through a user-confirmed per-device append-only protocol. Keep strict CAS as the default and retain immutable history with authenticated tip merging. Expose the mode and warnings in Settings and document the security and operational limits.
vastsa
changed the title
Mirror the append-only WebDAV protocol, warning, and retention semantics in the required Chinese specification pair so documentation checks cover the new behavior.
vastsa
added a commit
that referenced
this pull request
Sep 22, 2026
main's #838 added ADR 0301 (append-only WebDAV compatibility mode), so the compaction fallback ADR moves to 0302 with every reference updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- Allow an explicit LAN-only HTTP acknowledgement in Cloud Sync settings.\n- Reject public HTTP, unspecified IPs, and strict-mode WebDAV servers that ignore conditional writes.\n- Record an endpoint-specific 502 missing-object response after probing so compatible gateways can initialize safely.\n- Add an explicitly confirmed append-only compatibility mode for servers that ignore conditional headers: bounded PROPFIND capability probing, per-device encrypted heads, authenticated tip merging, immutable-history retention, and no unsafe cleanup.\n- Keep strict CAS as the default and show the compatibility warning/confirmation in all shipped locales.\n\n## Validation\n- cargo fmt --all -- --check\n- cargo test -p host-core config_sync --locked (31 passed)\n- cargo clippy -p host-core --all-targets (pass; one pre-existing warning in user_skills.rs)\n- pnpm build:js\n- pnpm lint\n- pnpm --filter @pi-desktop/desktop typecheck\n- pnpm --filter @pi-desktop/desktop test (2578 passed)\n- pnpm --filter @pi-desktop/i18n test (25 passed)\n- config-sync settings tests (3 passed)\n- pnpm test:e2e:boot (3 scenarios passed)\n\nNo real WebDAV service, provider, or user desktop was contacted.