Skip to content

fix(windows): publish portable build as zip - #857

Merged
vastsa merged 1 commit into
mainfrom
fix/windows-zip-portable
Sep 22, 2026
Merged

fix(windows): publish portable build as zip#857
vastsa merged 1 commit into
mainfrom
fix/windows-zip-portable

Conversation

@vastsa

@vastsa vastsa commented Sep 22, 2026

Copy link
Copy Markdown
Owner

Summary

  • replace the self-extracting Windows portable target with a normal ZIP
  • build NSIS and ZIP separately so distribution metadata keeps installed and portable update behavior distinct
  • preserve the Windows portable artifact name and document the extracted, non-admin launch flow

Validation

  • targeted packaging, updater, window-menu, and runtime contract tests: 20 passed
  • pnpm docs:check: passed
  • pnpm check:pr-base: passed
  • native Windows package/E2E: not run locally; requires a Windows runner
  • desktop typecheck remains blocked by the pre-existing unexported ConfigSyncRemoteMode / config-sync state mismatch

@vastsa
fix(windows): publish portable build as zip
56e8d5a 
Replace the self-extracting Windows portable target with a normal ZIP and
stamp its distribution metadata so extracted builds keep manual update
delivery without affecting NSIS installs.
Copilot AI lite review requested due to automatic review settings September 22, 2026 07:03
Copilot AI reviewed Sep 22, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@vastsa
vastsa merged commit 4d6db7e into main Sep 22, 2026
4 checks passed
@vastsa
vastsa deleted the fix/windows-zip-portable branch September 22, 2026 07:10
milebye pushed a commit to milebye/scoop-bucket that referenced this pull request Sep 23, 2026
PI Desktop Bucket
pi-desktop: track the upstream portable zip (0.15.6)
10a5872 
Upstream switched the Windows portable artifact from an NSIS .exe to a plain
.zip in v0.15.4 (vastsa/PI-Desktop#857). The manifest still pointed at
PI-Desktop-Portable-<ver>.exe#/dl.7z, so checkver resolved no asset and the
bucket silently stopped updating at 0.14.8.

Point the URL at the zip and drop the now-unneeded NSIS unpack step; the zip
already contains PI-Desktop.exe at its root.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vastsa