fix(settings): reconcile image bindings when removing provider models - #873
Merged
Merged
Conversation
Treat explicit provider-model removal as releasing its image binding, including legacy selections whose capability checkbox was untouched. Keep the existing chat-default repair when the same save removes it.
Keep the image default row visible when removal clears the active binding so the settings page explains the unavailable state while preserving the remaining candidates.
…ementation The branch's final semantics clear the image default when the removed model was the default, even when another candidate remains; the Configuration paragraph, the new removal section (both locales), the zh e2e scenario and the desktop e2e assertion still described the earlier fallback rule.
Owner
|
维护者侧处理完毕,head 我做的两件事
修复代码本身( 留档的后续项(不阻塞本次合入,建议另开 issue)
|
vastsa
added a commit
to hui455/PI-Desktop
that referenced
this pull request
Sep 22, 2026
Conflict resolution: keep this branch's provider-save feedback paragraph and take main's updated removal wording (vastsa#873), so both locales state the clear semantics; keep both new E2E scenarios and both desktop e2e scenario names.
This was referenced Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题与改动
从服务商的已选模型中移除默认生图模型并保存时,如果没有操作生图复选框,保存流程会跳过生图设置同步,留下不可用的默认绑定。
保存现在会清除已移除模型的生图候选并清空生图默认值;即使还有其他可用候选,也不会自动切换,直到用户主动选择新的默认模型。取消编辑保持原配置。若同次保存也移除了聊天默认模型,保留原有的聊天默认值修复行为。外部停用、失效绑定的展示规则不变。
同步中英文图片生成规格与 E2E-IMAGES-remove-configured-model 场景。无 IPC、数据库 schema、凭据或权限变更。
验证