Repository navigation
fix(settings): keep rename and selected models visible - #920
Merged
vastsa merged 1 commit intoSep 23, 2026
Merged
Conversation
Owner
|
感谢 pr,我正在重新设计模型这块页面,现在交互越来越麻烦,用户心智要求越来越高 |
This was referenced Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In three-column mode, Electron's native HTML preview could cover the session rename dialog. The provider editor also expanded the first selected model automatically, pushing the remaining checked model names below the fold and making the selection look blank.
Change
Relates to #904.
Validation
node --test apps/desktop/test/session-rename.test.mjs apps/desktop/test/provider-model-config.test.mjs apps/desktop/test/model-advanced-capabilities.test.mjs— 44 passedPI_DIALOG_ARTIFACT_DIR=/tmp/pi904-fixed node scripts/test-dialog-overflow.mjs— 36 passed, including native-preview suppression and four visible selected model rowselectron-vite buildpasseddistartifacts were rebuilt and rerun separately — 32 passed