Repository navigation
fix(release): make Windows packaging compatible with Node 24 - #932
Merged
Merged
Conversation
The v0.15.5 release tag reached the Windows packaging helper, but Node 24 could not spawn the pnpm.cmd shim and returned EINVAL. Launch the shim through the Windows shell and cover the contract with a regression assertion.\n\nBump the stable release to 0.15.6 because the existing tag is immutable, refresh the bundled model catalog, and keep GPT-6 Astra, Sol, and Luna in every shipped changelog locale.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm.cmdshim through the shell sodist:winno longer fails withspawn EINVALon the hosted Node 24 runner0.15.6becausev0.15.5is already immutableValidation
pnpm build:jspnpm --filter @pi-desktop/desktop typecheckpnpm lintpnpm --filter @pi-desktop/shared testpnpm test:e2e:hosted-searchpnpm test:e2e:provider-api-stylepnpm check:agent-policypnpm check:release-docs 0.15.6The previous
v0.15.5release attempt passed verification, Linux, pi-host, and both macOS packaging jobs but failed twice in the Windows packaging helper withspawn EINVAL; this PR addresses that root cause.