Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/next/src/server/base-server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2540,7 +2540,10 @@ export default abstract class Server<
// literal dynamic route ('/[slug]') instead of actual URL, so overwriting to initPathname
// will transform back the resolved url to the dynamic route pathname.
if (!(this.minimalMode && isErrorPathname)) {
request.url = `${initPathname}${parsedInitUrl.search || ''}`
request.url =
routeModule && isAppRouteRouteModule(routeModule)
? formatUrl({ pathname, query })
: `${initPathname}${parsedInitUrl.search || ''}`
}

// propagate the request context for dev
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
export const runtime = 'edge'

export function GET(request) {
return Response.json(Object.fromEntries(request.nextUrl.searchParams))
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
export function GET(request) {
return Response.json(Object.fromEntries(request.nextUrl.searchParams))
}
7 changes: 7 additions & 0 deletions test/e2e/middleware-rewrites/app/middleware.js
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,13 @@ export async function middleware(request) {
)
}

if (url.pathname.startsWith('/rewrite-query/')) {
const rewriteUrl = request.nextUrl.clone()
rewriteUrl.pathname = `/api${url.pathname}`
rewriteUrl.searchParams.set('added', '1')
return NextResponse.rewrite(rewriteUrl)
}

if (url.pathname === '/foo/bar') {
const rewriteUrl = request.nextUrl.clone()
rewriteUrl.pathname = '/api/proxy/bar/'
Expand Down
21 changes: 21 additions & 0 deletions test/e2e/middleware-rewrites/test/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ const isAdapterTest = process.env.NEXT_ENABLE_ADAPTER === '1'
describe('Middleware Rewrite', () => {
const { next, isNextDeploy } = nextTestSetup({
files: {
app: new FileRef(join(__dirname, '../app/app')),
pages: new FileRef(join(__dirname, '../app/pages')),
'next.config.js': new FileRef(join(__dirname, '../app/next.config.js')),
'middleware.js': new FileRef(join(__dirname, '../app/middleware.js')),
Expand Down Expand Up @@ -118,6 +119,26 @@ describe('Middleware Rewrite', () => {
})
})

it('should preserve middleware rewrite query in App Routes', async () => {
const [nodeResponse, edgeResponse] = await Promise.all(
['node', 'edge'].map((runtime) =>
next.fetch(`/rewrite-query/${runtime}?key=value`)
)
)

expect(nodeResponse.status).toBe(200)
expect(edgeResponse.status).toBe(200)

await expect(nodeResponse.json()).resolves.toEqual({
key: 'value',
added: '1',
})
await expect(edgeResponse.json()).resolves.toEqual({
key: 'value',
added: '1',
})
})

it('should handle static dynamic rewrite from middleware correctly', async () => {
const browser = await next.browser('/rewrite-to-static')

Expand Down