Support tlsmode - #555
Conversation
kevinkarch88
left a comment
kevinkarch88
left a comment
There was a problem hiding this comment.
Tests look good and thorough to me. Approving.
There was a problem hiding this comment.
similar nit, I would change the description slightly to say "...signed by a trusted certificate authority."
There was a problem hiding this comment.
and same change to the relevant part of verify-full
There was a problem hiding this comment.
good adjustment, more secure
There was a problem hiding this comment.
Would this logic be clearer as a function that takes tlsmode_options and ssl_options and returns the correct tlsmode?
tlsmode = _initTLSMode(self.options.get('tlsmode'), self.options.get('ssl'))
There was a problem hiding this comment.
Yes, this part will be wrapped into a function eventually, since this affects future works of making load balancing TLS encrypted, so I didn't do it. Now commit is pushed.
There was a problem hiding this comment.
Nice and clean. I like your implementation of this class.
DMickens
left a comment
DMickens
left a comment
There was a problem hiding this comment.
These changes look great
4 participants
tlsmode.sslis not set, change its behavior from tlsmode='disable' to tlsmode='prefer'.