WIP impact diagnostics fns#17
Open
pratikunterwegs wants to merge 32 commits into
Open
Conversation
…ots central impact estimates, coverage and fvps. Associated documentation also added from attempts at roxygen!
zegibney
reviewed
Jul 13, 2026
zegibney
reviewed
Jul 13, 2026
| #' @export | ||
| plot_impact <- function( | ||
| data, | ||
| country = PINE, |
There was a problem hiding this comment.
I think this will fail for certain diseases. Although we use PINE as a default for a quick glace at estimates instead of running every country, there will not be some diseases in PINE countries, for example YF.
There was a problem hiding this comment.
Could we add something like, if some or any of PINE present, plot those? Likely at least one PINE country will be present in all disease datasets.
Contributor
Author
There was a problem hiding this comment.
I think a failure for a disease-country mismatch is okay, we provide PINE as a sensible default but there's no expectation that country is always present - the function will error informatively, and the user can change either data or country.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is WIP replacing #15.
PR desc copied over:
This PR adds additional functions from [https://github.com/vimc/montagu-reports/tree/main/src/rapid-model-run-impact] a key report for the VIMC Science & Policy team.
Functions added generate central estimate impact plots and coverage and fvp plots per year, country and view.
First attempt at ensuring functions are package-ready/ utilising roxygen etc. so any comment welcome.
TODO's in script fn_plotting_impact.R with specific questions. I understand testing may need to be stronger/ the next step.