You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
However the linked issue doesn't seem to have a direct solution, and I haven't investigated if we can tweak this directly. Strangely though, the short commit hash shouldn't be colliding since it's displaying fine for me locally:
> git rev-parse 8211
error: short object ID 8211 is ambiguous
hint: The candidates are:
hint: 82111bfb4 commit 2024-05-20 - fix: types
hint: 82116a58c tree
hint: 8211f8632 blob
8211
fatal: ambiguous argument '8211': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
Maybe GitHub collects more hashes not cloned locally.
@bluwy It seems that the upstream has not planned to solve this problem for a long time. Perhaps we can add a script to replace the short hash with the full hash value.
If you want to patch, you can use https://pnpm.io/cli/patch, e.g. pnpm patch conventional-changelog-cli. Though I'm not sure if that's the code we want to edit, you could also pass a nested package name to edit.
Activity
bluwy commentedon May 27, 2024
We probably need to use the full commit hash in the linked url - conventional-changelog/conventional-changelog#476
However the linked issue doesn't seem to have a direct solution, and I haven't investigated if we can tweak this directly. Strangely though, the short commit hash shouldn't be colliding since it's displaying fine for me locally:
A shorter hash would look like:
Maybe GitHub collects more hashes not cloned locally.
btea commentedon Jul 4, 2024
@bluwy It seems that the upstream has not planned to solve this problem for a long time. Perhaps we can add a script to replace the short hash with the full hash value.
bluwy commentedon Jul 17, 2024
Fine by me 👍 Maybe we can also use pnpm to patch it.
btea commentedon Jul 17, 2024
conventional-changelogis called directly withnpx, and I don't know how to patch it. Currently, I can only write a script to update the hash value.bluwy commentedon Jul 17, 2024
If you want to patch, you can use https://pnpm.io/cli/patch, e.g.
pnpm patch conventional-changelog-cli. Though I'm not sure if that's the code we want to edit, you could also pass a nested package name to edit.bluwy commentedon Jul 22, 2024
I think we can close this with #17709 merged