Repository navigation
Conversation
oliverkurth
reviewed
Sep 1, 2026
| # UI modules, which need not be a module-level dependency of the ISO | ||
| # builder. These go to the ISO's RPMS/ only, not into self.initrd_pkgs, | ||
| # so the initrd does not grow. | ||
| from stigenable import KS_STIG_PACKAGES |
Collaborator
There was a problem hiding this comment.
Can you please move this to the top of the file, with import stigenable, and refer to it as stigenable.KS_STIG_PACKAGES?
Contributor
Author
There was a problem hiding this comment.
git apply --check (strict, no fuzz) returns 0 on v2.8, v2.9 and origin/master; after applying, isoBuilder.py compiles, import stigenable works headless, isoBuilder.stigenable.KS_STIG_PACKAGES is stigenable.KS_STIG_PACKAGES holds, and on all three the hunk lands in downloadPkgs() with the import at module level.
Tested on minimal-iso x86_64. Ongoing full-iso build should be the same. aarch64 not tested.
dcasota
force-pushed
the
upstream/isobuilder-installer-pkgs-on-media
branch
from
September 1, 2026 18:16
5a6fff7 to
aefaa84
Compare
dcasota
added a commit
to dcasota/photon
that referenced
this pull request
Sep 1, 2026
Regenerated 0008 from github.com/dcasota/photon-os-installer @ 56ae83c, which carries the form requested in review on vmware/photon-os-installer#49: a module-level `import stigenable` referenced as `stigenable.KS_STIG_PACKAGES`, rather than a local `from stigenable import KS_STIG_PACKAGES` inside downloadPkgs(). Package selection is unchanged; only where the import happens moves. Change-Id: Idbc6e7565c915770305eeb22a7198ba649735ca0 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JW73JTCUGRcaNTUEQcAMtf
dcasota
added a commit
to dcasota/photon
that referenced
this pull request
Sep 1, 2026
Regenerated 0008 from github.com/dcasota/photon-os-installer @ 56ae83c, which carries the form requested in review on vmware/photon-os-installer#49: a module-level `import stigenable` referenced as `stigenable.KS_STIG_PACKAGES`, rather than a local `from stigenable import KS_STIG_PACKAGES` inside downloadPkgs(). Package selection is unchanged; only where the import happens moves. Change-Id: I3be44f73d323be4bb243c85be2e88d10a6d8f8a8 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JW73JTCUGRcaNTUEQcAMtf
dcasota
added a commit
to dcasota/photon
that referenced
this pull request
Sep 1, 2026
Regenerated 0008 from github.com/dcasota/photon-os-installer @ 56ae83c, which carries the form requested in review on vmware/photon-os-installer#49: a module-level `import stigenable` referenced as `stigenable.KS_STIG_PACKAGES`, rather than a local `from stigenable import KS_STIG_PACKAGES` inside downloadPkgs(). Package selection is unchanged; only where the import happens moves. Change-Id: Iff902337549b191c714ff4ef8a42564017feb402 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JW73JTCUGRcaNTUEQcAMtf
dcasota
added a commit
to dcasota/photon
that referenced
this pull request
Sep 16, 2026
Regenerated 0008 from github.com/dcasota/photon-os-installer @ 56ae83c, which carries the form requested in review on vmware/photon-os-installer#49: a module-level `import stigenable` referenced as `stigenable.KS_STIG_PACKAGES`, rather than a local `from stigenable import KS_STIG_PACKAGES` inside downloadPkgs(). Package selection is unchanged; only where the import happens moves. Change-Id: Iff902337549b191c714ff4ef8a42564017feb402 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JW73JTCUGRcaNTUEQcAMtf
dcasota
added a commit
to dcasota/photon
that referenced
this pull request
Sep 16, 2026
Regenerated 0008 from github.com/dcasota/photon-os-installer @ 56ae83c, which carries the form requested in review on vmware/photon-os-installer#49: a module-level `import stigenable` referenced as `stigenable.KS_STIG_PACKAGES`, rather than a local `from stigenable import KS_STIG_PACKAGES` inside downloadPkgs(). Package selection is unchanged; only where the import happens moves. Change-Id: Iff902337549b191c714ff4ef8a42564017feb402 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JW73JTCUGRcaNTUEQcAMtf
dcasota
added a commit
to dcasota/photon
that referenced
this pull request
Sep 16, 2026
Regenerated 0008 from github.com/dcasota/photon-os-installer @ 56ae83c, which carries the form requested in review on vmware/photon-os-installer#49: a module-level `import stigenable` referenced as `stigenable.KS_STIG_PACKAGES`, rather than a local `from stigenable import KS_STIG_PACKAGES` inside downloadPkgs(). Package selection is unchanged; only where the import happens moves. Change-Id: Iff902337549b191c714ff4ef8a42564017feb402 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JW73JTCUGRcaNTUEQcAMtf
dcasota
added a commit
to dcasota/photon
that referenced
this pull request
Sep 16, 2026
Regenerated 0008 from github.com/dcasota/photon-os-installer @ 56ae83c, which carries the form requested in review on vmware/photon-os-installer#49: a module-level `import stigenable` referenced as `stigenable.KS_STIG_PACKAGES`, rather than a local `from stigenable import KS_STIG_PACKAGES` inside downloadPkgs(). Package selection is unchanged; only where the import happens moves. Change-Id: I3be44f73d323be4bb243c85be2e88d10a6d8f8a8 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JW73JTCUGRcaNTUEQcAMtf
dcasota
added a commit
to dcasota/photon
that referenced
this pull request
Sep 17, 2026
Regenerated 0008 from github.com/dcasota/photon-os-installer @ 56ae83c, which carries the form requested in review on vmware/photon-os-installer#49: a module-level `import stigenable` referenced as `stigenable.KS_STIG_PACKAGES`, rather than a local `from stigenable import KS_STIG_PACKAGES` inside downloadPkgs(). Package selection is unchanged; only where the import happens moves. Change-Id: Iff902337549b191c714ff4ef8a42564017feb402 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JW73JTCUGRcaNTUEQcAMtf
dcasota
added a commit
to dcasota/photon
that referenced
this pull request
Sep 17, 2026
Regenerated 0008 from github.com/dcasota/photon-os-installer @ 56ae83c, which carries the form requested in review on vmware/photon-os-installer#49: a module-level `import stigenable` referenced as `stigenable.KS_STIG_PACKAGES`, rather than a local `from stigenable import KS_STIG_PACKAGES` inside downloadPkgs(). Package selection is unchanged; only where the import happens moves. Change-Id: I3be44f73d323be4bb243c85be2e88d10a6d8f8a8 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JW73JTCUGRcaNTUEQcAMtf
dcasota
added a commit
to dcasota/photon
that referenced
this pull request
Oct 7, 2026
Regenerated 0008 from github.com/dcasota/photon-os-installer @ 56ae83c, which carries the form requested in review on vmware/photon-os-installer#49: a module-level `import stigenable` referenced as `stigenable.KS_STIG_PACKAGES`, rather than a local `from stigenable import KS_STIG_PACKAGES` inside downloadPkgs(). Package selection is unchanged; only where the import happens moves. Change-Id: Iff902337549b191c714ff4ef8a42564017feb402 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
dcasota
added a commit
to dcasota/photon
that referenced
this pull request
Oct 7, 2026
Regenerated 0008 from github.com/dcasota/photon-os-installer @ 56ae83c, which carries the form requested in review on vmware/photon-os-installer#49: a module-level `import stigenable` referenced as `stigenable.KS_STIG_PACKAGES`, rather than a local `from stigenable import KS_STIG_PACKAGES` inside downloadPkgs(). Package selection is unchanged; only where the import happens moves. Change-Id: I3be44f73d323be4bb243c85be2e88d10a6d8f8a8 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
dcasota
added a commit
to dcasota/photon
that referenced
this pull request
Oct 7, 2026
Regenerated 0008 from github.com/dcasota/photon-os-installer @ 56ae83c, which carries the form requested in review on vmware/photon-os-installer#49: a module-level `import stigenable` referenced as `stigenable.KS_STIG_PACKAGES`, rather than a local `from stigenable import KS_STIG_PACKAGES` inside downloadPkgs(). Package selection is unchanged; only where the import happens moves. Change-Id: Iff902337549b191c714ff4ef8a42564017feb402 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
dcasota
added a commit
to dcasota/photon
that referenced
this pull request
Oct 7, 2026
Regenerated 0008 from github.com/dcasota/photon-os-installer @ 56ae83c, which carries the form requested in review on vmware/photon-os-installer#49: a module-level `import stigenable` referenced as `stigenable.KS_STIG_PACKAGES`, rather than a local `from stigenable import KS_STIG_PACKAGES` inside downloadPkgs(). Package selection is unchanged; only where the import happens moves. Change-Id: I3be44f73d323be4bb243c85be2e88d10a6d8f8a8 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Two gaps in how the download list is built. 1. The STIG menu offers "Apply STIG hardening", which makes the installer request KS_STIG_PACKAGES at install time. Those names were never added to the ISO's own RPMS/, so on a minimal ISO - where downloadPkgs() resolves a closure rather than copying every rpm - the packages simply were not there and the install failed with "Error(1011) : No matching packages". Use stigenable.KS_STIG_PACKAGES rather than restating the names in a package list file; restating them is exactly how the media and the installer drifted apart. 2. Packages named via --initrd-pkgs never reached this list either. Only the list *file* was parsed, so a package requested on the command line could not be installed into the initrd from the ISO's own RPMS/. Both extend self.pkg_list only, so they land in the ISO's RPMS/ and the initrd does not grow. Verified end to end: a minimal ISO built with this carries 290 rpms instead of 254, including selinux-policy, libselinux-utils, rsyslog, aide, openssl-fips-provider and ntpsec; the UI wizard's STIG option completes; and the installed system comes up SELinux Enforcing with 0 failed ansible tasks. Signed-off-by: Daniel Casota <dcasota@gmail.com> Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
dcasota
force-pushed
the
upstream/isobuilder-installer-pkgs-on-media
branch
from
October 9, 2026 07:33
aefaa84 to
b5b1627
Compare
dcasota
added a commit
to dcasota/photon
that referenced
this pull request
Oct 29, 2026
Regenerated 0008 from github.com/dcasota/photon-os-installer @ 56ae83c, which carries the form requested in review on vmware/photon-os-installer#49: a module-level `import stigenable` referenced as `stigenable.KS_STIG_PACKAGES`, rather than a local `from stigenable import KS_STIG_PACKAGES` inside downloadPkgs(). Package selection is unchanged; only where the import happens moves. Change-Id: Iff902337549b191c714ff4ef8a42564017feb402 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
dcasota
added a commit
to dcasota/photon
that referenced
this pull request
Nov 1, 2026
Regenerated 0008 from github.com/dcasota/photon-os-installer @ 56ae83c, which carries the form requested in review on vmware/photon-os-installer#49: a module-level `import stigenable` referenced as `stigenable.KS_STIG_PACKAGES`, rather than a local `from stigenable import KS_STIG_PACKAGES` inside downloadPkgs(). Package selection is unchanged; only where the import happens moves. Change-Id: Iff902337549b191c714ff4ef8a42564017feb402 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
dcasota
added a commit
to dcasota/photon
that referenced
this pull request
Nov 1, 2026
Regenerated 0008 from github.com/dcasota/photon-os-installer @ 56ae83c, which carries the form requested in review on vmware/photon-os-installer#49: a module-level `import stigenable` referenced as `stigenable.KS_STIG_PACKAGES`, rather than a local `from stigenable import KS_STIG_PACKAGES` inside downloadPkgs(). Package selection is unchanged; only where the import happens moves. Change-Id: I3be44f73d323be4bb243c85be2e88d10a6d8f8a8 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
dcasota
added a commit
to dcasota/photon
that referenced
this pull request
Nov 2, 2026
Regenerated 0008 from github.com/dcasota/photon-os-installer @ 56ae83c, which carries the form requested in review on vmware/photon-os-installer#49: a module-level `import stigenable` referenced as `stigenable.KS_STIG_PACKAGES`, rather than a local `from stigenable import KS_STIG_PACKAGES` inside downloadPkgs(). Package selection is unchanged; only where the import happens moves. Change-Id: I3be44f73d323be4bb243c85be2e88d10a6d8f8a8 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
The installer's STIG menu offers "Apply STIG hardening", which makes the installer request
KS_STIG_PACKAGESat install time. Those names were never added to the ISO's ownRPMS/.On a minimal ISO that is fatal, because
downloadPkgs()resolves a dependency closure rather than copying every rpm — so the packages are simply not on the media, and the install dies with:A second, related gap: packages named via
--initrd-pkgsnever reached the download list either. Only the list file was parsed, so a package requested on the command line could not be installed into the initrd from the ISO's ownRPMS/.The change
isoBuilder.pyextendsself.pkg_listwith:stigenable.KS_STIG_PACKAGES— the installer's own declaration of what the STIG option installs.--initrd-pkgs.Both extend
self.pkg_listonly, so they land in the ISO'sRPMS/and the initrd does not grow.The first point is deliberately a reference to the installer's own list rather than a restatement of those names in a package-list file. Restating them is exactly how the media and the installer drifted apart in the first place: the menu kept offering an option the media could not honour.
Verification
A minimal ISO built with this change carries 290 rpms instead of 254, including
selinux-policy,libselinux-utils,rsyslog,aide,openssl-fips-providerandntpsec.Installed from that media:
Error(1011)Lint, matching what
lint-checks.shruns in CI:stigenableis imported at module level, soisoBuildernow depends on it at import time. That transitively pulls incursesviamenu.py/window.py, which matters because the ISO builder runs headless in a container — so it is checked rather than assumed. ImportingisoBuilderwith noTERMand no tty succeeds, and the resulting package selection is unchanged:(
cursesonly touches the terminal atinitscr(), not at import.)The RPM ships the whole package —
photon-os-installer.specinstalls%{python3_sitelib}/*, which includesstigenable.py— anddocker/Dockerfileinstalls that RPM into the final image, so the new import resolves whereverisoBuilderactually runs. There is no import cycle:stigenableimports onlyactionresult,menuandwindow, none of which reach back toisoBuilder.The 290-rpm count above includes
ntp,libselinux-utilsandlibgcrypt, which #47 drops from the STIG set.🤖 Generated with Claude Code