chore(tools): prevent false-positive <repeat> replacement on trailing plus#1524
Merged
fengmk2 merged 4 commits intoMay 7, 2026
Merged
Conversation
… plus
The regex `/\++\n/g` matched any line ending with a single `+`,
including legitimate text like "Vite+". Changed to `/\+{2,}\n/g`
to only match pnpm's actual repeated `+` progress indicators.
✅ Deploy Preview for viteplus-preview canceled.
|
nurazon59
marked this pull request as draft
May 6, 2026 14:48
fengmk2
approved these changes
May 6, 2026
nurazon59
force-pushed
the
fix/tools/plus-repeat-false-positive
branch
from
May 6, 2026 15:56
a862802 to
abacb6b
Compare
nurazon59
marked this pull request as ready for review
May 6, 2026 16:03
nurazon59
force-pushed
the
fix/tools/plus-repeat-false-positive
branch
from
May 6, 2026 16:03
b3d68e4 to
050e586
Compare
fengmk2
reviewed
May 7, 2026
fengmk2
left a comment
fengmk2
left a comment
Member
There was a problem hiding this comment.
@nurazon59 Thanks, I will regen the snap test diff before merge.
fengmk2
changed the title
<repeat> replacement on trailing plus<repeat> replacement on trailing plus
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered while reviewing CI results after approving #1508.
The regex
/\++\n/gwas overly aggressive and matched any line ending with a single+, including legitimate text like "Vite+" in the CLI help output.Changed to
/\+{2,}\n/gto only match pnpm's actual repeated+progress indicators (e.g.,+++).