Skip to content

Fix semantic conflict in vortex-array#8312

Merged
joseph-isaacs merged 2 commits into
developfrom
adamg/fix-semantic-conflict
Jun 9, 2026
Merged

Fix semantic conflict in vortex-array#8312
joseph-isaacs merged 2 commits into
developfrom
adamg/fix-semantic-conflict

Conversation

@AdamGS

@AdamGS AdamGS commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes a minor semantic conflict introduced by some recent PRs.

Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS requested review from a team and joseph-isaacs June 9, 2026 13:07
@AdamGS AdamGS added the changelog/fix A bug fix label Jun 9, 2026
@joseph-isaacs joseph-isaacs enabled auto-merge (squash) June 9, 2026 13:08
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@codspeed-hq

codspeed-hq Bot commented Jun 9, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 10.48%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 8 improved benchmarks
❌ 2 regressed benchmarks
✅ 1507 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation varbinview_zip_block_mask 2.9 ms 3.7 ms -21.56%
Simulation varbinview_zip_fragmented_mask 6.1 ms 6.9 ms -11.3%
Simulation bitwise_not_vortex_buffer_mut[128] 275.3 ns 216.9 ns +26.89%
Simulation rebuild_naive 140.9 µs 111.9 µs +25.83%
Simulation bitwise_not_vortex_buffer_mut[1024] 336.9 ns 278.6 ns +20.94%
Simulation extend_from_array_non_zctl_overlapping[(10000, 8)] 4.7 ms 4 ms +18.52%
Simulation bitwise_not_vortex_buffer_mut[2048] 400.6 ns 342.2 ns +17.05%
Simulation extend_from_array_non_zctl_overlapping[(1000, 8)] 527.7 µs 453.3 µs +16.41%
Simulation extend_from_array_zctl[(10000, 8)] 2.5 ms 2.2 ms +12.85%
Simulation extend_from_array_zctl[(1000, 8)] 290.6 µs 262.6 µs +10.67%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing adamg/fix-semantic-conflict (14e4171) with develop (ab78257)

Open in CodSpeed

@joseph-isaacs joseph-isaacs merged commit 69d2cfd into develop Jun 9, 2026
71 of 75 checks passed
@joseph-isaacs joseph-isaacs deleted the adamg/fix-semantic-conflict branch June 9, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants