Arithmetic Operations#8398
Conversation
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: "Nicholas Gates" <nick@nickgates.com>
Merging this PR will improve performance by 34.11%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | chunked_bool_canonical_into[(1000, 10)] |
20.3 µs | 35.3 µs | -42.33% |
| ❌ | Simulation | chunked_varbinview_canonical_into[(1000, 10)] |
161.7 µs | 198 µs | -18.36% |
| ❌ | Simulation | chunked_varbinview_into_canonical[(1000, 10)] |
176.9 µs | 212.9 µs | -16.93% |
| ❌ | Simulation | chunked_varbinview_canonical_into[(100, 100)] |
273.3 µs | 309.2 µs | -11.61% |
| ❌ | Simulation | chunked_varbinview_into_canonical[(100, 100)] |
324.5 µs | 361 µs | -10.1% |
| ⚡ | Simulation | mul_i8_nonnull |
456.6 µs | 131.9 µs | ×3.5 |
| ⚡ | Simulation | mul_i16_nonnull |
546.6 µs | 234 µs | ×2.3 |
| ⚡ | Simulation | mul_i32_constant |
675.2 µs | 313.3 µs | ×2.2 |
| ⚡ | Simulation | mul_i32_nullable |
990.1 µs | 479.8 µs | ×2.1 |
| ⚡ | Simulation | sub_i64_constant |
1,070.6 µs | 562.3 µs | +90.39% |
| ⚡ | Simulation | add_i64_nullable |
1,499.6 µs | 841.6 µs | +78.19% |
| ⚡ | Simulation | mul_i32_nonnull |
726.3 µs | 444.9 µs | +63.26% |
| ⚡ | Simulation | list_i32_large |
333.3 µs | 217.1 µs | +53.56% |
| ⚡ | Simulation | take_filter_list_small_uncached_random_mask_random_indices[256, 10] |
193 µs | 136.3 µs | +41.64% |
| ⚡ | Simulation | scalar_subtract |
5.3 ms | 3.8 ms | +39.53% |
| ⚡ | Simulation | take_filter_list_slice_mask_sequential_indices[768, 50] |
159 µs | 115.4 µs | +37.77% |
| ⚡ | Simulation | take_filter_list_slice_mask_sequential_indices[256, 50] |
158.6 µs | 116.3 µs | +36.39% |
| ⚡ | Simulation | add_i64_nonnull |
1,084.4 µs | 807.8 µs | +34.24% |
| ⚡ | Simulation | take_filter_list_small_random_mask_random_indices[256, 10] |
176.9 µs | 132.9 µs | +33.14% |
| ⚡ | Simulation | take_filter_list_slice_mask_random_indices[256, 50] |
177.3 µs | 133.2 µs | +33.07% |
| ... | ... | ... | ... | ... | ... |
ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing ngates/arithmetic (2db3431) with develop (67a2b22)
Footnotes
-
10 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: "Nicholas Gates" <nick@nickgates.com>
Signed-off-by: "Nicholas Gates" <nick@nickgates.com>
Signed-off-by: "Nicholas Gates" <nick@nickgates.com>
Signed-off-by: "Nicholas Gates" <nick@nickgates.com>
The only remaining calls to Arrow are for kleene logic, arithmetic, and LIKE expressions. If we make these native Vortex, we can pull out Arrow into a vortex-arrow engine/integration crate. --------- Signed-off-by: Nicholas Gates <nick@nickgates.com> Signed-off-by: "Nicholas Gates" <nick@nickgates.com>
The only remaining calls to Arrow are for kleene logic, arithmetic, and LIKE expressions.
If we make these native Vortex, we can pull out Arrow into a vortex-arrow engine/integration crate.