Skip to content

Arithmetic Operations#8398

Merged
gatesn merged 10 commits into
developfrom
ngates/arithmetic
Jun 17, 2026
Merged

Arithmetic Operations#8398
gatesn merged 10 commits into
developfrom
ngates/arithmetic

Conversation

@gatesn

@gatesn gatesn commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

The only remaining calls to Arrow are for kleene logic, arithmetic, and LIKE expressions.

If we make these native Vortex, we can pull out Arrow into a vortex-arrow engine/integration crate.

gatesn added 3 commits June 12, 2026 15:58
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: "Nicholas Gates" <nick@nickgates.com>
@codspeed-hq

codspeed-hq Bot commented Jun 12, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 34.11%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 30 improved benchmarks
❌ 5 regressed benchmarks
✅ 1510 untouched benchmarks
⏩ 10 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_bool_canonical_into[(1000, 10)] 20.3 µs 35.3 µs -42.33%
Simulation chunked_varbinview_canonical_into[(1000, 10)] 161.7 µs 198 µs -18.36%
Simulation chunked_varbinview_into_canonical[(1000, 10)] 176.9 µs 212.9 µs -16.93%
Simulation chunked_varbinview_canonical_into[(100, 100)] 273.3 µs 309.2 µs -11.61%
Simulation chunked_varbinview_into_canonical[(100, 100)] 324.5 µs 361 µs -10.1%
Simulation mul_i8_nonnull 456.6 µs 131.9 µs ×3.5
Simulation mul_i16_nonnull 546.6 µs 234 µs ×2.3
Simulation mul_i32_constant 675.2 µs 313.3 µs ×2.2
Simulation mul_i32_nullable 990.1 µs 479.8 µs ×2.1
Simulation sub_i64_constant 1,070.6 µs 562.3 µs +90.39%
Simulation add_i64_nullable 1,499.6 µs 841.6 µs +78.19%
Simulation mul_i32_nonnull 726.3 µs 444.9 µs +63.26%
Simulation list_i32_large 333.3 µs 217.1 µs +53.56%
Simulation take_filter_list_small_uncached_random_mask_random_indices[256, 10] 193 µs 136.3 µs +41.64%
Simulation scalar_subtract 5.3 ms 3.8 ms +39.53%
Simulation take_filter_list_slice_mask_sequential_indices[768, 50] 159 µs 115.4 µs +37.77%
Simulation take_filter_list_slice_mask_sequential_indices[256, 50] 158.6 µs 116.3 µs +36.39%
Simulation add_i64_nonnull 1,084.4 µs 807.8 µs +34.24%
Simulation take_filter_list_small_random_mask_random_indices[256, 10] 176.9 µs 132.9 µs +33.14%
Simulation take_filter_list_slice_mask_random_indices[256, 50] 177.3 µs 133.2 µs +33.07%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing ngates/arithmetic (2db3431) with develop (67a2b22)

Open in CodSpeed

Footnotes

  1. 10 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

gatesn added 2 commits June 12, 2026 18:40
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn added the changelog/performance A performance improvement label Jun 12, 2026
gatesn added 3 commits June 16, 2026 15:22
Signed-off-by: "Nicholas Gates" <nick@nickgates.com>
Signed-off-by: "Nicholas Gates" <nick@nickgates.com>
Signed-off-by: "Nicholas Gates" <nick@nickgates.com>
@gatesn gatesn marked this pull request as ready for review June 16, 2026 22:45
@gatesn gatesn requested a review from a team June 16, 2026 22:45
@gatesn gatesn enabled auto-merge (squash) June 16, 2026 22:46
@gatesn gatesn disabled auto-merge June 16, 2026 23:56
@gatesn gatesn enabled auto-merge (squash) June 17, 2026 00:15
@gatesn gatesn disabled auto-merge June 17, 2026 01:01
@gatesn gatesn merged commit 7dbe5ac into develop Jun 17, 2026
66 of 69 checks passed
@gatesn gatesn deleted the ngates/arithmetic branch June 17, 2026 01:01
AdamGS pushed a commit that referenced this pull request Jun 17, 2026
The only remaining calls to Arrow are for kleene logic, arithmetic, and
LIKE expressions.

If we make these native Vortex, we can pull out Arrow into a
vortex-arrow engine/integration crate.

---------

Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: "Nicholas Gates" <nick@nickgates.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/performance A performance improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants