Skip to content

Touch up some of the interfaces and docs in vortex-datafusion#8485

Merged
AdamGS merged 1 commit into
developfrom
adamg/add-some-df-apis
Jun 18, 2026
Merged

Touch up some of the interfaces and docs in vortex-datafusion#8485
AdamGS merged 1 commit into
developfrom
adamg/add-some-df-apis

Conversation

@AdamGS

@AdamGS AdamGS commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR mostly touches up some of the interfaces, and exposes a few extra types that might be helpful for users.

  1. Makes our type conversion traits public
  2. Exposes DefaultExpressionConverter, so users can fall back to it if they need to in their own implementations.
  3. VortexSink if they want to explore write physical plans
  4. Introduces VortexSource::predicate, to explore read physical plans.

Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS requested review from a team, a10y, onursatici and robert3005 June 18, 2026 09:27
@AdamGS AdamGS added changelog/chore A trivial change ext/datafusion Relates to the DataFusion integration labels Jun 18, 2026
@codspeed-hq

codspeed-hq Bot commented Jun 18, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 33.68%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 4 improved benchmarks
✅ 1577 untouched benchmarks
⏩ 3 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_bool_canonical_into[(1000, 10)] 34.9 µs 20.5 µs +69.78%
Simulation bitwise_not_vortex_buffer_mut[128] 244.4 ns 186.1 ns +31.34%
Simulation bitwise_not_vortex_buffer_mut[1024] 304.7 ns 246.4 ns +23.68%
Simulation bitwise_not_vortex_buffer_mut[2048] 427.8 ns 369.4 ns +15.79%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing adamg/add-some-df-apis (734821a) with develop (4f52cbc)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@AdamGS AdamGS merged commit 7f170ce into develop Jun 18, 2026
80 of 83 checks passed
@AdamGS AdamGS deleted the adamg/add-some-df-apis branch June 18, 2026 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change ext/datafusion Relates to the DataFusion integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants