Skip to content

Remove LEGACY_SESSION from benchmarks and back compat tests#8554

Merged
robert3005 merged 2 commits into
developfrom
rk/morenolegacy
Jun 23, 2026
Merged

Remove LEGACY_SESSION from benchmarks and back compat tests#8554
robert3005 merged 2 commits into
developfrom
rk/morenolegacy

Conversation

@robert3005

Copy link
Copy Markdown
Contributor

Getting closer

Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 requested a review from a team June 23, 2026 14:44
@0ax1

0ax1 commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

@claude anything sus?

@0ax1 0ax1 self-requested a review June 23, 2026 14:45
@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Claude encountered an error after 3m 24s —— View job


I'll analyze this and get back to you.

@robert3005 robert3005 added the changelog/chore A trivial change label Jun 23, 2026

@AdamGS AdamGS left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If benchmarks look good, lets ship it?

@codspeed-hq

codspeed-hq Bot commented Jun 23, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 4 improved benchmarks
❌ 2 regressed benchmarks
✅ 1577 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation sum_i32_nullable_all_valid 36.5 µs 171.3 µs -78.71%
Simulation slice_empty_vortex 310 ns 368.3 ns -15.84%
Simulation chunked_bool_canonical_into[(1000, 10)] 26.8 µs 16.1 µs +66.73%
Simulation bitwise_not_vortex_buffer_mut[128] 273.6 ns 215.3 ns +27.1%
Simulation bitwise_not_vortex_buffer_mut[1024] 333.9 ns 275.6 ns +21.17%
Simulation bitwise_not_vortex_buffer_mut[2048] 427.8 ns 369.4 ns +15.79%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/morenolegacy (a3aa8f3) with develop (71319b7)

Open in CodSpeed

Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 enabled auto-merge (squash) June 23, 2026 15:09
@robert3005 robert3005 merged commit ba700ca into develop Jun 23, 2026
69 checks passed
@robert3005 robert3005 deleted the rk/morenolegacy branch June 23, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants