Convert extension type scalars to Value correctly#8635
Conversation
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
Merging this PR will not alter performance
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | chunked_varbinview_opt_canonical_into[(1000, 10)] |
169.6 µs | 206.2 µs | -17.74% |
| ❌ | Simulation | chunked_varbinview_into_canonical[(1000, 10)] |
169.3 µs | 205.5 µs | -17.63% |
| ❌ | Simulation | chunked_varbinview_opt_into_canonical[(1000, 10)] |
183.4 µs | 219.6 µs | -16.48% |
| ❌ | Simulation | slice_empty_vortex |
339.4 ns | 397.8 ns | -14.66% |
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[128] |
273.6 ns | 215.3 ns | +27.1% |
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[1024] |
333.9 ns | 275.6 ns | +21.17% |
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[2048] |
427.8 ns | 369.4 ns | +15.79% |
| ⚡ | Simulation | chunked_varbinview_into_canonical[(100, 100)] |
306.4 µs | 271.6 µs | +12.82% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing myrrc/convert-scalar-to-value (04e6d83) with develop (c7e8ae9)
Footnotes
-
4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Before this PR, we were converting Vortex extension dtypes e.g. timestamp to underlying types i.e. i64 instead of TIMESTAMP while creating a Duckdb Value.