Skip to content

Convert extension type scalars to Value correctly#8635

Merged
myrrc merged 1 commit into
developfrom
myrrc/convert-scalar-to-value
Jul 1, 2026
Merged

Convert extension type scalars to Value correctly#8635
myrrc merged 1 commit into
developfrom
myrrc/convert-scalar-to-value

Conversation

@myrrc

@myrrc myrrc commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Before this PR, we were converting Vortex extension dtypes e.g. timestamp to underlying types i.e. i64 instead of TIMESTAMP while creating a Duckdb Value.

Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
@myrrc myrrc requested review from a team and 0ax1 July 1, 2026 09:54
@myrrc myrrc added the changelog/fix A bug fix label Jul 1, 2026
@myrrc myrrc enabled auto-merge (squash) July 1, 2026 09:55
@myrrc myrrc merged commit d9ded20 into develop Jul 1, 2026
79 of 80 checks passed
@myrrc myrrc deleted the myrrc/convert-scalar-to-value branch July 1, 2026 10:01
@codspeed-hq

codspeed-hq Bot commented Jul 1, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 4 improved benchmarks
❌ 4 regressed benchmarks
✅ 1587 untouched benchmarks
⏩ 4 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_varbinview_opt_canonical_into[(1000, 10)] 169.6 µs 206.2 µs -17.74%
Simulation chunked_varbinview_into_canonical[(1000, 10)] 169.3 µs 205.5 µs -17.63%
Simulation chunked_varbinview_opt_into_canonical[(1000, 10)] 183.4 µs 219.6 µs -16.48%
Simulation slice_empty_vortex 339.4 ns 397.8 ns -14.66%
Simulation bitwise_not_vortex_buffer_mut[128] 273.6 ns 215.3 ns +27.1%
Simulation bitwise_not_vortex_buffer_mut[1024] 333.9 ns 275.6 ns +21.17%
Simulation bitwise_not_vortex_buffer_mut[2048] 427.8 ns 369.4 ns +15.79%
Simulation chunked_varbinview_into_canonical[(100, 100)] 306.4 µs 271.6 µs +12.82%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing myrrc/convert-scalar-to-value (04e6d83) with develop (c7e8ae9)

Open in CodSpeed

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants