FFI: replace vx_string/vx_binary with vx_view#8668
Conversation
Merging this PR will not alter performance
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
fd4843b to
dfd9d1d
Compare
0ax1
left a comment
There was a problem hiding this comment.
What is the value of splitting these types. It seems we now use str also for buffers that are just bytes.
5d4c34f to
6bad344
Compare
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
vx_string/vx_binary is not a zero-copy abstraction. For every utf/binary view you allocate memory. This PR replaces both with a vx_view non-owning view akin to C++'s string_view.