Skip to content

Grow list builders as we append elements to it#8673

Merged
robert3005 merged 1 commit into
developfrom
rk/growbuilders
Jul 7, 2026
Merged

Grow list builders as we append elements to it#8673
robert3005 merged 1 commit into
developfrom
rk/growbuilders

Conversation

@robert3005

Copy link
Copy Markdown
Contributor

Grow List/ListView builders when we append to them. Since they're variable
length we can't preallocate them

Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 added the changelog/fix A bug fix label Jul 7, 2026
@codspeed-hq

codspeed-hq Bot commented Jul 7, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 21.26%

⚡ 3 improved benchmarks
✅ 1604 untouched benchmarks
⏩ 42 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation bitwise_not_vortex_buffer_mut[128] 273.6 ns 215.3 ns +27.1%
Simulation bitwise_not_vortex_buffer_mut[1024] 333.9 ns 275.6 ns +21.17%
Simulation bitwise_not_vortex_buffer_mut[2048] 427.8 ns 369.4 ns +15.79%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/growbuilders (761cf46) with develop (0d50342)

Open in CodSpeed

Footnotes

  1. 42 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@robert3005 robert3005 merged commit 9a42615 into develop Jul 7, 2026
78 of 80 checks passed
@robert3005 robert3005 deleted the rk/growbuilders branch July 7, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants