Add support for ARM64 - #60
Open
RafaelCintron wants to merge 1 commit into
Open
RafaelCintron wants to merge 1 commit into
RafaelCintron wants to merge 1 commit into
Conversation
Fix `webgfx.py` so `--target-arch arm64` is propagated to each `Project` instance instead of defaulting back to the host architecture. This allows ARM64 commands to correctly use: * `out/release_arm64` for builds * `--browser=release_arm64` when running Chromium GPU tests * `chrome.exe` from the ARM64 output directory Changes * Pass the CLI-selected architecture from `Webgfx` to `Project`. * Normalize the lowercase CLI value `arm64` to the existing `Util.ARM64` constant. * Add regression tests verifying: * ARM64 projects select `out/release_arm64` . * `Webgfx` forwards `--target-arch arm64` to `Project`. * Added architecture unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
webgfx.pyso--target-arch arm64is propagated to eachProjectinstance instead of defaulting back to the host architecture.This allows ARM64 commands to correctly use:
out/release_arm64for builds--browser=release_arm64when running Chromium GPU testschrome.exefrom the ARM64 output directoryChanges
WebgfxtoProject.arm64to the existingUtil.ARM64constant.out/release_arm64.Webgfxforwards--target-arch arm64toProject.