Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/nonce-manager-zero-nonce.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"viem": patch
---

Fixed `nonceManager` handing out a duplicate nonce when the previously consumed nonce was `0`.
13 changes: 13 additions & 0 deletions src/utils/nonceManager.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,19 @@ test('get preserves consumed nonce cache', async () => {
expect(await nonceManager.consume(mainnetArgs)).toBe(2)
})

test('consumed nonce 0 is not re-served by a stale source', async () => {
const nonceManager = createNonceManager({
source: {
get: () => 0,
set: () => {},
},
})

expect(await nonceManager.consume(mainnetArgs)).toBe(0)
expect(await nonceManager.get(mainnetArgs)).toBe(1)
expect(await nonceManager.consume(mainnetArgs)).toBe(1)
})

test('failed sendTransaction resets consumed nonce', async () => {
const nonceManager = createNonceManager({
source: jsonRpc(),
Expand Down
4 changes: 2 additions & 2 deletions src/utils/nonceManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,8 @@ export function createNonceManager(
promise = (async () => {
try {
const nonce = await source.get({ address, chainId, client })
const previousNonce = nonceMap.get(key) ?? 0
if (previousNonce > 0 && nonce <= previousNonce)
const previousNonce = nonceMap.get(key)
if (previousNonce !== undefined && nonce <= previousNonce)
return previousNonce + 1
nonceMap.delete(key)
return nonce
Expand Down
Loading