Override "Accept-Language" header if WebDriver BiDi emulated language is present.

[lutien]

• At least two implementers are interested (and none opposed):
  • Chromium
  • Mozilla
• Tests are written and can be reviewed and commented upon at:
  • [Gecko Bug 1995691] [wdspec] Add checks for overriding "Accept-Language" header with "emulation.setLocaleOverride". web-platform-tests/wpt#55977
• Implementation bugs are filed:
  • Chromium: Respect emulation.setLocaleOverride in navigator.language and Accept-Language GoogleChromeLabs/chromium-bidi#3863
  • Gecko: https://bugzilla.mozilla.org/show_bug.cgi?id=1995691
  • WebKit: N/A
• MDN issue is filed: N/A
• The top of this comment includes a clear commit message to use.

(See WHATWG Working Mode: Changes for more details.)

---

Preview | Diff

[lutien]

@sadym-chromium, could you create an issue for it on your side?

[sadym-chromium]

@sadym-chromium, could you create an issue for it on your side?

@lutien GoogleChromeLabs/chromium-bidi#3863

[lutien]

Hey, @annevk, could you maybe take another look? 🙏🏻

[annevk]

Looks good modulo some minor grammar and wrapping nits.

[annevk]

I hadn't looked at https://w3c.github.io/webdriver-bidi/#webdriver-bidi-emulated-language before but it appears that returns null or a string and we need a byte sequence here. So you need to encode the return value.

[lutien]

I hadn't looked at https://w3c.github.io/webdriver-bidi/#webdriver-bidi-emulated-language before but it appears that returns null or a string and we need a byte sequence here. So you need to encode the return value.

Ah, right, updated ✅

[annevk]

There's a ` missing. I also find this confusing as this could also be read as a three-tuple.

[lutien]

Alright, I've added "`". And moved encoding into a separate step to avoid having the three-tuple situation.

[annevk]

Thanks @lutien!