Conversation
annevk
reviewed
Oct 15, 2025
annevk
left a comment
annevk
left a comment
Member
There was a problem hiding this comment.
This is a good start, but now that you're making these algorithms more complex, you should turn them into a list of steps similar to most other algorithms. Then they will become easier to read.
Co-authored-by: Maksim Sadym <69349599+sadym-chromium@users.noreply.github.com>
lutien
marked this pull request as ready for review
October 21, 2025 14:39
Contributor
Author
|
The WebDriver BiDi part is merged. So this should be ready for review. |
zcorpan
requested changes
Oct 28, 2025
zcorpan
approved these changes
Nov 17, 2025
annevk
reviewed
Nov 18, 2025
| <li>Let <var>emulatedLanguage</var> be the <span>WebDriver BiDi emulated language</span> for | ||
| <span>this</span>'s <span>relevant settings object</span></li> | ||
|
|
||
| <li>If <var>emulatedLanguage</var> is not null, return <var>emulatedLanguage</var>.</li> |
| <span>this</span>'s <span>relevant settings object</span></li> | ||
|
|
||
| <li>If <var>emulatedLanguage</var> is not null, return a <span>frozen array</span> containing | ||
| <var>emulatedLanguage</var>.</li> |
| </ol> | ||
|
|
||
| <p>The same object must be returned until the user agent needs to return different values, or | ||
| values in a different order, or <var>emulatedLanguage</var> is updated.</p> |
Member
There was a problem hiding this comment.
This should really follow from the algorithm and some internal state. We shouldn't really have out-of-band steps that change the requirements.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR to add the required hook in WebDriver BiDi spec: w3c/webdriver-bidi#1017.
emulation.setLocaleOverrideinnavigator.languageandAccept-LanguageGoogleChromeLabs/chromium-bidi#3863(See WHATWG Working Mode: Changes for more details.)
/acknowledgements.html ( diff )
/infrastructure.html ( diff )
/system-state.html ( diff )