Remove Railo-era compatibility code from Plugins.cfc #1975

Activity

1. bpamiri

   added

   enhancement

   on Mar 15, 2026
2. bpamiri commented on Mar 16, 2026

   

   bpamiri

   on Mar 16, 2026

   CollaboratorAuthor

   More actions

   Analysis

   Synopsis

   Remove a Railo-specific Duplicate() workaround in $initializeMixins() (lines 303-306) that guards against a bug fixed in Railo 3.2. Since Lucee replaced Railo and all supported engines are Lucee, Adobe CF, or BoxLang, this is dead code.

   Merit Assessment

   Recommendation: Proceed

   • The Railo branch at line 303 (application[$wheels.appKey].serverName == "Railo") can never be true — Railo is not a supported engine and the server detection in onapplicationstart.cfc:36-45 only sets BoxLang, Lucee, or Adobe ColdFusion.
   • Removing it simplifies $initializeMixins() and eliminates a confusing conditional that misleads contributors into thinking Railo compatibility matters.
   • Zero risk of behavioral change since the branch is unreachable.

   Implementation Plan

   1. Edit vendor/wheels/Plugins.cfc:302-312 — Remove the Railo conditional branch. The current code:

      if (!StructKeyExists(variablesScope, "core")) {
          if (application[$wheels.appKey].serverName == "Railo") {
              variablesScope.core = Duplicate(variablesScope);
          } else {
              variablesScope.core = {};
              StructAppend(variablesScope.core, variablesScope);
              StructDelete(variablesScope.core, "$wheels");
          }
      }
      

      Becomes:

      if (!StructKeyExists(variablesScope, "core")) {
          variablesScope.core = {};
          StructAppend(variablesScope.core, variablesScope);
          StructDelete(variablesScope.core, "$wheels");
      }
      

   2. Run existing plugin tests — vendor/wheels/tests/specs/pluginsSpec.cfc covers mixin injection across controller, model, dispatch, and test targets. Existing tests are sufficient.
   3. Estimated complexity: Trivial — 3 lines removed, no new logic.

   Dependencies & Risks

   • No dependencies on other issues.
   • No breaking change risk — the removed branch was unreachable on all supported engines.
   • Could also audit for other Railo references across the codebase (search for "Railo") as a follow-up cleanup.

   ---

   Automated analysis by @claude — review and adjust as needed.

   👀React with 👀1Reacted by claude
3. bpamiri

   added

   phase:1-stabilizeBugs, cleanup, CI fixes — tackle firstBugs, cleanup, CI fixes — tackle first

   on Mar 16, 2026
4. bpamiri

   added a commit that references this issue on Mar 16, 2026

   Remove Railo compatibility workaround from $initializeMixins

   ...

   This issue will close once commit ddbcfe3 is merged into the 'develop' branch.

   ddbcfe3
5. bpamiri

   added this to the v3.1 milestone on Mar 17, 2026
6. bpamiri

   closed this as completedin ddbcfe3on Mar 17, 2026