Repository navigation
Trivia sweep: accumulated reviewer nits from the 2026-06 remediation campaign #2977
Description
Problem
A batch of cosmetic/doc items recorded by reviewers across the campaign, none worth an individual PR, all worth one sweep (coverage audit 2026-06-10):
-
vendor/wheels/model/validations.cfc:946—$evaluateLogicalExpressionmissingLCase: throws on uppercaseEQ/LToperator tokens in development. - fix(dispatch): block /wheels/* dev UI unless environment is development #2903's three stale references:
Public.cfc:47docblock,InvokeMethodSpec.cfc:46comment,debug-panel.mdxguide example (all still describe the old denylist gate). - fix(controller): make $acceptableFormats honor onlyProvides per-action restrictions #2901 follow-up:
renderWithdocs note about per-actiononlyProvidesnow being enforced. - Reviewer nits noted-not-blocking on fix(controller): sendEmail multipart handling and sendFile path containment #2922, fix(dispatch): Global cache cull, date parsing, CF version gate, existence caches #2933, fix(test): browser skip path, dialog listener detach, launcher lifecycle and locking #2934, fix(migrator): addIndex alias order, dbtype caching, helper dedup, diffAll rethrow #2937, fix(dispatch): require POST+password for /wheels/cli destructive ops, contain dbDump #2947 (each PR's review thread has the specifics — wording, doc-comments, minor naming).
Suggested approach
One chore/docs PR sweeping the list; each checkbox links back to its source PR thread.
Source
Internal framework review 2026-06-09 remediation campaign; coverage audit 2026-06-10.
Activity
wheels-bot commentedon Jun 10, 2026
Wheels Bot — Triage
Classified as bug.
Suspected layer
model— see.ai/wheels/snippets/model-snippets.mdand the validations module (vendor/wheels/model/validations.cfc). The primary defect lives in the condition-evaluation helpers.Fix sketch
The dominant fix targets
vendor/wheels/model/validations.cfc$evaluateLogicalExpression(line 958, not 946 as quoted) —local.tokens[2]is handed to$resolveOperatorwithoutLCase, so uppercaseEQ/LT/etc. tokens fall through the case-sensitive switch (line 985) and throwUnsupported operator in condition. Mirror the existingLCase()already applied at line 875 in$parseSimpleCondition. The remaining sweep items are non-code-behavior cleanups in three files (vendor/wheels/controller/Public.cfc:47docblock,vendor/wheels/tests/specs/controller/InvokeMethodSpec.cfc:46comment,web/sites/guides/.../debug-panel.mdxexample) plus arenderWithdocs note for the #2901 follow-up, plus reviewer nits across #2922 / #2933 / #2934 / #2937 / #2947 whose specifics need to be read from each PR's review thread.Confidence:
lowThe bug fix shape is mechanical, but the sweep's full scope is not derivable from this issue body — the reviewer nits on five separate PRs are referenced by number only, so the deliverable can't be enumerated without reading each PR's review thread. Keeping manual.
<!-- wheels-bot:triage:2977 -->
<!-- wheels-bot:triage-class:bug -->
fix: sweep accumulated reviewer nits from the 2026-06 campaign (#2992)