Repository navigation
cli: wheels generate controller Name a,b silently emits invalid CFML — comma-joined action list becomes one action #3112
Description
Repro (released 4.0.3, also expected on develop)
wheels generate controller Authors index,show
# create app/controllers/Authors.cfc
# create app/views/authors/index,show.cfm <-- one file, comma in the name
grep -n function app/controllers/Authors.cfc
# 20: function index,show() { <-- invalid CFML, won't compileThe documented form (wheels generate controller Authors index show, space-separated — code-generation.mdx:104,114) works correctly. But the comma form is the natural guess for anyone coming from validatesPresenceOf("a,b")-style comma lists elsewhere in Wheels, and the generator accepts it silently, reports success, and writes a controller that errors at first request plus a view file with a comma in its filename.
Fix options
- Split positional action tokens on commas before generating (friendliest), or
- Validate each action name against a CFML-identifier pattern and reject with a clear error.
Either way the generator must not write function index,show().
Dedupe: no overlap with #3072–#3090 or in-flight PRs #3100–#3108. Found during the P2 guide-behavioral-audit (p2-2-cliref) while verifying code-generation.mdx.
🤖 Generated with Claude Code
Activity
wheels-bot commentedon Jun 12, 2026
Wheels Bot — Triage
Classified as bug.
The report shows
wheels generate controller Authors index,showsilently emittingfunction index,show()(invalid CFML that fails to compile) plus a view fileindex,show.cfmwith a comma in its name. There is a clear "what happened" (function index,show()written, reports success) vs. "what I expected" (the space-separated formindex showworks). Reproducible in isolation.Suspected layer
cli— the code generator. The comma-joined token is passed through as a single action element rather than being split or validated.Fix sketch
The action list arrives as
["index,show"](one element) inCodeGen.cfc::generateController(cli/lucli/services/CodeGen.cfc:117), which writesfunction ACTION()per element and a view file per element. The likely fix is at the boundary where positional action tokens are collected — either split each token on commas before generating (soindex,showbecomes["index","show"], mirroringvalidatesPresenceOf("a,b")list semantics), or validate each action against a CFML-identifier pattern and reject with a clear error. Touch points:CodeGen.cfc::generateControllerand possibly the positional-arg parsing incli/lucli/Module.cfc. Mechanical, no design trade-offs, no cross-engine concern.Confidence:
highClear repro with expected-vs-actual, unambiguous single layer (cli generator), and a mechanical one-spot fix; none of the auto-downgrade rules (security/middleware/migration/DI/deploy/cross-engine) apply.
<!-- wheels-bot:triage:3112 -->
<!-- wheels-bot:triage-class:bug -->
<!-- wheels-bot:triage-confidence:high -->
wheels-bot commentedon Jun 12, 2026
Wheels Bot — Fix proposed
Draft PR: #3131
Spec:
cli/lucli/tests/specs/services/CodeGenSpec.cfc— added failing → passing cases assertingactions = ["index,show"]yieldsfunction index()/function show()(neverindex,show), plus trim/de-dup coverage.Implementation:
cli/lucli/services/CodeGen.cfc(newnormalizeActions()splits comma-joined tokens, returns the normalized list) andcli/lucli/Module.cfc(view loop now uses the normalized actions so view filenames match the controller methods).A human review is required before merge. The Reviewer will weigh in shortly. Doc updates (MDX guides,
.ai/wheels/,CLAUDE.md) are handled separately bybot-update-docs.yml.fix(cli): split comma-joined action tokens in generate controller (#3131