Repository navigation
perf(controller): apply a per-class precomputed method struct instead of the per-instance mixin loop #4149
Description
Measured on: RustCFML v0.693.0 (the CI pin), develop 0255f0d53, production mode, SQLite, Apple M3 Ultra.
Problem
Every request builds a new controller instance, and Controller.init() mixes in the framework's controller and view methods one at a time. #2897 / #3236 already cache the integration plan per base path. But the replay loop in $integrateFunctions (vendor/wheels/Controller.cfc) still runs per instance: about 550 methods, each with 2 StructKeyExists checks and 2 struct writes (variables and this).
Measured on RustCFML:
| Measurement | Result |
|---|---|
Controller instance on the request path: controller("Products", {controller: "products", action: "index"}) |
4.47 ms (median of 3 × 100 calls) |
CFML sampling profiler, a renderText("ok") action (400 requests) |
Controller.init → $integrateFunctions is 47% of request samples |
| CFML sampling profiler, a 50-row list page (440 requests) | 15.7% of request samples |
Warm request latency, dispatch only (renderText) |
9.03 ms median, against a 0.69 ms bare-engine page |
| Copying the same 550 method references into two structs with a CFML loop | 1,146 µs |
The same copy with 2× StructAppend(target, source, false) |
43 µs (27x faster) |
Not measured yet: Lucee, Adobe or BoxLang. The loop runs on every engine, so the relative cost there is worth checking.
Proposal
Precompute, once per controller class (alongside the cached plan), the final struct of name → ref entries to add, plus the super<name> aliases. That struct is the same for every instance of a class, because inheritance and the mixin-override set are fixed per class. Each new instance then applies it with StructAppend(variables, precomputed, false) and StructAppend(this, precomputed, false) instead of the per-method loop.
The same pattern may apply to Model.cfc's $integrateFunctions for returnAs="objects" rows.
Constraints
- Keep the override and
super<name>semantics fromsuper<name>originals are only registered for model overrides — controller/view helper overrides get nosuperLinkTo()#3325 / Pin super<name> / super.<name> delegation for model, controller and view overrides with specs #3933 exactly. The existing specs pin them. - Invalidate the precomputed struct on reload with the existing plan cache (Flaky bare NullPointerException in model instantiation on Lucee 7 (cleared by reload) #3457 / fix(perf): rebuild cached integration plans containing null function refs #3460 validation).
Acceptance
- The
super<name>specs (Pin super<name> / super.<name> delegation for model, controller and view overrides with specs #3933) pass on all engines. - Controller construction time is measured before and after on RustCFML and Lucee 7 and posted on the PR.
Activity
perf(controller): apply a per-class cached method integration instead…