Repository navigation
docs(guides): correct stale 4.1 statements on error email, reload, upgrades and install - #3932
Merged
Merged
Conversation
…grades and install - production-config: errorEmailAddress defaults to "" since 4.1.2 (GHSA-8gcv-3v9h-7gj2); with no recipient no error email is sent and a one-time warning goes to wheels.log - environments-and-configuration: an empty reloadPassword fails closed since 4.0.4 (#3062); #3059 is fixed, not open - performance-notes: describe the released fixes (4.0.6 #3236, 4.1.0 #3461/#3462/#3464, 4.1.1 #3656) instead of pointing at bleeding-edge - manual-installation: use the 4.1.2 release asset names and tag - upgrade: document the 4.1.0 app template drift advisory (#3379) - 3x-to-4x: the wheels.Testbox upgrade-check rule shipped in 4.0.4 - manual-upgrades: caution that the 4.1.1 .env boolean fix (#3641) must be applied by hand to the app-owned public/Application.cfc Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Peter Amiri <peter@alurium.com>
Collaborator
Author
|
rev1-r1 review @ 44169ac: APPROVE. I checked every version claim against the release tags and the code.
Nit (optional): "the sender falls back to the recipient" skips one step. The chain is |
errorEmailFromAddress, then errorEmailAddress, then the recipient (EventMethods.cfc). Review nit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Peter Amiri <peter@alurium.com>
Collaborator
Author
This was referenced Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Several 4.1 guide pages still describe behaviour that changed in 4.0.4–4.1.2.
What
All changes are under
web/sites/guides/src/content/docs/v4-1-0/:deployment/production-config.mdx. It said an empty error-email recipient "still tries to send… fails silently". Since 4.1.2,errorEmailAddressdefaults to""(GHSA-8gcv-3v9h-7gj2): with no recipient, no error email is sent and Wheels writes a one-time warning towheels.log, so set it explicitly. Checked againstevents/init/debugging.cfmandevents/EventMethods.cfc.core-concepts/environments-and-configuration.mdx. It said a blankreloadPassword"permits anonymous?reload=true", but it has failed closed since 4.0.4 (Reload-password contract drift: empty password leaves?reload=trueopen to anonymous restarts, warm-app wrong-password attempts are never logged or rate-limited, and the boot warning misstates behavior #3062). It also calledwheels reloadreports "Application reloaded successfully." when the HTTP reload request fails (4xx/5xx) #3059 an open issue; it was fixed in 4.0.4.upgrading/performance-notes.mdx. It said the fix was "not in any stable release yet" and pointed to the bleeding-edge channel. It now lists the released work: 4.0.6 (perf(model): cache mixin-integration plan to fix per-instance overhead (#3213) #3236), 4.1.0 (perf(model): inherit the model mixin surface instead of copying it per instance #3462 compile-time includes, perf(model): construct model instances without the DI resolve + reflective invoke #3464 direct constructor), and 4.1.1 (perf(controller): narrow flash locking to the session scope #3656 per-session flash locking, by @zspitzer).start-here/manual-installation.mdx. It named the4.0.5artifacts and tag. It now uses 4.1.2, with a note to use the latest release. Asset names were checked against the v4.1.2 release.command-line-tools/wheels-commands/upgrade.mdx. Documents the template drift advisory that every run includes since 4.1.0 (Element wo is undefined in a Java object of type class [Ljava.lang.String #3379): a byte-exact compare ofpublic/Application.cfcandpublic/index.cfmagainst the bundled template, reported by file name.upgrading/3x-to-4x.mdx. It said thewheels.Testcheck was "on develop / post-4.0.3"; it shipped in 4.0.4.upgrading/manual-upgrades.mdx. A new caution: the 4.1.1.envboolean fix (A .env value of numeric 1 is silently coerced to the boolean true (seven copies of the parser) #3641/fix(env): stop coercing a .env value of numeric 1 to the boolean true #3642) lives in the app-ownedpublic/Application.cfc, so existing apps patch it by hand. It shows the before and after lines from the template.Docs-only.
🤖 Generated with Claude Code