Repository navigation
test: fetch the onboarding SQLite driver through the verified helper - #4596
Merged
Merged
Conversation
tools/test-onboarding.sh was the last script downloading sqlite-jdbc without a hash check. It now uses tools/ci/fetch-sqlite-jdbc.sh with 3.49.1.0's pinned SHA-256, the same as test-local.sh and test-cli-local.sh. Overriding SQLITE_JDBC_VERSION now also requires SQLITE_JDBC_SHA256; without it the script exits with a message. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Peter Amiri <peter@alurium.com>
Collaborator
Author
|
rev1-r3 review @ dadcc6a: APPROVE This closes the INFO from my #4594 review.
PR CI: 12 pass, 3 skipping, 0 fail. Up to date with develop, MERGEABLE. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tools/test-onboarding.shwas the last script that downloaded the SQLite JDBC driver without a hash check (curl -fsSL). It now fetches the driver throughtools/ci/fetch-sqlite-jdbc.sh, using 3.49.1.0's pinned SHA-256, the same astest-local.shandtest-cli-local.shsince #4594.SQLITE_JDBC_VERSIONcan still be overridden. A version other than 3.49.1.0 now also needsSQLITE_JDBC_SHA256; without it, the script exits at the start with a message.Verification
HOME(Express and driver downloaded)sqlite-jdbc 3.49.1.0 downloaded and verified, then one restart; 49 pass, 0 fail, 3 skippedSQLITE_JDBC_VERSION=3.50.3.0withoutSQLITE_JDBC_SHA256SQLITE_JDBC_VERSION=3.50.3.0 needs SQLITE_JDBC_SHA256 (the jar's SHA-256) as well.~/.wheelsand~/.lucliwere inventoried before and after: unchanged.shellcheck -S warningreports the same count asdevelop.🤖 Generated with Claude Code