feat: drive sorting integration(WPB-25179)#21707
Open
arjita-mitra wants to merge 5 commits into
Open
Conversation
arjita-mitra
changed the title
Expose the stable setSort state setter from useCellsSorting and use it to reset conversation sort on view, conversation, and hash changes. This avoids recreating a reset callback on each render, which was causing the reset effect to run after sorting and fire a second default request.
|
arjita-mitra
requested review from
e-maad,
ikotarac,
otto-the-bot,
screendriver,
thisisamir98 and
zskhan
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorting of all columns
Sort persistence —
Sort selected in browse view → carry into search view of same conversation? Vice versa?
Sort selected in Conversation A's browse → carry to Conversation B?
Sort selected in Shared Drive → carry to global Drive (and back)?
based on our last discussions with @olga Anna Skoczylas we reset in all 3
Rule of thumb: user-applied sort always wins. Default is mtime/desc whenever content is being actively searched/filtered. Default is BE natural (folders-first) when the view is in a passive/browse state (browse mode, or search open but nothing entered).