untouchable input without selected key fix

[ghost]

untouchable input without selected key fix

[TomyLobo]

can you describe the problem in more detail please?
I don't understand it

about the code: I'm not quite up-to-date, but from the name "ShowOutput", I would expect it to always do something. maybe make an error text in an else?

[TomyLobo]

(to make changes, use git commit --amend and then git push -f)

[ghost]

http://youtu.be/OatSv5Q4hX8?hd=1
Copied this check from wire_output.
Probably shouldn't include 'untouchable' to commit message, it is caused by prop protection addon. This error interrupts code, so neither undo menu nor prop protection see spanwed wire input.

[TomyLobo]

"interrupts code" isn't quite the right technical term ("cancels event processing" would be better) but i get what you mean

Can you verify if this code works?
Feel free to put it in your pull request if you want your name on it :)

function ENT:ShowOutput(value)
    local keyName = self.keygroup and keylist[self.keygroup + 1] or "Unknown, "..self.keygroup

    self:SetOverlayText( "Numpad Input ("..keyName..")\n(" .. self.value_off .. " - " .. self.value_on .. ") = " .. value )
end

Commit message might be something like "Fixed nil error in Numpad Input."

[ghost]

It's so hard to do such a small fix :|
I wanted to make some more fixes sometime later, but if every small fix will be that long...
Anyway, should i also change Numpad Output's ShowOutput to a new style?

[ColonelThirtyTwo]

Not all fixes are this long, but we need to know what is being fixed and if there's a better solution.

[TomyLobo]

@vigcom if you want, sure, for consistency

[TomyLobo]

still waiting for @vigcom :)

[ghost]

Accidently removed my forked repo when were testing something, new pull request incoming.