Skip to content

fix: Ensure consistent hook execution order and add docs - #1081

Merged
aklinker1 merged 2 commits into
mainfrom
module-execution-order
Oct 19, 2024
Merged

aklinker1 merged 2 commits into
mainfrom
module-execution-order

Conversation

@aklinker1

@aklinker1 aklinker1 commented Oct 19, 2024 •

Copy link
Copy Markdown
Member

This closes #1070

@netlify

netlify Bot commented Oct 19, 2024 •

Copy link
Copy Markdown

✅ Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 3362c05
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/6713209640cdac0008f1ba9a
😎 Deploy Preview https://deploy-preview-1081--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pkg-pr-new

pkg-pr-new Bot commented Oct 19, 2024 •

Copy link
Copy Markdown

Open in Stackblitz

@wxt-dev/auto-icons

pnpm add https://pkg.pr.new/@wxt-dev/auto-icons@1081

@wxt-dev/module-solid

pnpm add https://pkg.pr.new/@wxt-dev/module-solid@1081

@wxt-dev/module-svelte

pnpm add https://pkg.pr.new/@wxt-dev/module-svelte@1081

@wxt-dev/module-react

pnpm add https://pkg.pr.new/@wxt-dev/module-react@1081

@wxt-dev/module-vue

pnpm add https://pkg.pr.new/@wxt-dev/module-vue@1081

wxt

pnpm add https://pkg.pr.new/wxt@1081

@wxt-dev/i18n

pnpm add https://pkg.pr.new/@wxt-dev/i18n@1081

commit: 3362c05

@codecov

codecov Bot commented Oct 19, 2024 •

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 20.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 81.59%. Comparing base (d09cf6d) to head (3362c05).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/wxt/src/core/wxt.ts 14.28% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1081      +/-   ##
==========================================
- Coverage   82.16%   81.59%   -0.58%     
==========================================
  Files         127      127              
  Lines        6646     6661      +15     
  Branches     1110     1106       -4     
==========================================
- Hits         5461     5435      -26     
- Misses       1171     1212      +41     
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aklinker1 aklinker1 changed the title fix: Ensure consistent hook execution order fix: Ensure consistent hook execution order and add docs Oct 19, 2024
@aklinker1
aklinker1 marked this pull request as ready for review October 19, 2024 03:02
@aklinker1
aklinker1 merged commit cee1424 into main Oct 19, 2024
@aklinker1
aklinker1 deleted the module-execution-order branch October 19, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cleanup and document module execution order

1 participant