Repository navigation
feat: Automatically remove top-level MV2-only or MV3-only keys - #518
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #518 +/- ##
==========================================
+ Coverage 86.50% 86.53% +0.02%
==========================================
Files 111 111
Lines 8798 8847 +49
Branches 867 871 +4
==========================================
+ Hits 7611 7656 +45
- Misses 1173 1177 +4
Partials 14 14 ☔ View full report in Codecov by Sentry. |
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
aklinker1
marked this pull request as ready for review
March 3, 2024 15:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #517.
Instead of having to use a function to change the keys between manifest versions, you can just include both the MV2 and MV3 keys in a single object. When targetting MV2, all MV3 keys will be removed. When targetting MV3, all MV2 keys will be removed.
Before
After