style(convolution): drop unused import, fix isort ordering#3613
Merged
Conversation
…t ordering Cat 3 (F401): remove unused not_implemented_func imported from xrspatial.utils (refactor leftover, not re-exported). Cat 4 (isort): merge the two split 'from xrspatial.utils import' lines into a single alphabetised block. No behavioural change; flake8 + isort clean, 6 convolution tests pass. Includes sweep-style-state.csv update for convolution.
This was referenced Jul 6, 2026
brendancol
added a commit
to brendancol/xarray-spatial
that referenced
this pull request
Jul 6, 2026
…y-contrib#3616/xarray-contrib#3619/xarray-contrib#3620 Keep both sides in convolution.py (_validate_kernel from this branch, _PARALLEL_KERNEL_LOCK + parallel=True kernel from main) and both test blocks. State CSV: main's file with this branch's convolution row.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Style sweep cleanup for
xrspatial/convolution.py.Two findings, both flagged by the project's own tooling:
not_implemented_funcwas imported fromxrspatial.utilsbut never used. It's a refactor leftover and isn't re-exported, so removing it is safe.xrspatial.utilsimport was split across two separatefrom ... importstatements. Merged into one alphabetised block.No behavioural change. flake8 and isort are clean on the module after the fix, and the 6 convolution tests pass.