Skip to content

Feature: Add Windows arm64 support - #511

Merged
xerial merged 2 commits into
xerial:masterfrom
imsudiproy:arm-support
Sep 26, 2023
Merged

Feature: Add Windows arm64 support#511
xerial merged 2 commits into
xerial:masterfrom
imsudiproy:arm-support

Conversation

@imsudiproy

Copy link
Copy Markdown
Contributor

This PR adds support for windows arm64

@imsudiproy

Copy link
Copy Markdown
Contributor Author

Working on adding armv7 support.

@xerial

xerial commented Sep 25, 2023

Copy link
Copy Markdown
Owner

Thanks. Have you tested it on a real Windows arm64 machine (e.g., Surface Pro X)?

@imsudiproy

imsudiproy commented Sep 25, 2023

Copy link
Copy Markdown
Contributor Author

No, I don't have Windows arm64 machine. It is better to test it before merging.

@xerial

xerial commented Sep 25, 2023

Copy link
Copy Markdown
Owner

Ok. I'll check this PR by using my own one :) Give me some time

@imsudiproy

Copy link
Copy Markdown
Contributor Author

Okay, thanks. Till then I'll try to add support for armv7. Currently I am facing error related to vqtbl1q_u8.
The error suggests using vtbl1_u8 instead of vqtbl1q_u8. On searching about this, I got to know that in ARM NEON, vqtbl1q_u8 operates on 128-bit vectors, but we should use vtbl1_u8 for 64-bit vectors.

@xerial

xerial commented Sep 26, 2023

Copy link
Copy Markdown
Owner

Ok. Let's merge this PR first (I'll test it later), and create another PR for Windows + armv7.

@xerial xerial changed the title Feature: add windows arm64 support Feature: Add Windows arm64 support Sep 26, 2023
@xerial
xerial merged commit ee96b64 into xerial:master Sep 26, 2023
@xerial

xerial commented Sep 26, 2023

Copy link
Copy Markdown
Owner

@imsudiproy It seems this build was not using the right compilation parameters. Working on a fix at #518

@imsudiproy

Copy link
Copy Markdown
Contributor Author

@xerial Thank you for addressing the issue.

@xerial

xerial commented Sep 27, 2023

Copy link
Copy Markdown
Owner

With #518 and #520, I could run snappy-java in Windows on arm64 (My Surface Pro X)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants