Skip to content

Add hasWrapper function in clean and remove command - #3205

Merged
arcanis merged 1 commit into
yarnpkg:masterfrom
voxsim:fix-remove-command
Apr 20, 2017
Merged

arcanis merged 1 commit into
yarnpkg:masterfrom
voxsim:fix-remove-command

Conversation

@voxsim

@voxsim voxsim commented Apr 20, 2017 •

Copy link
Copy Markdown
Contributor

@arcanis sorry I totally forgot to inform you that clean and remove command miss a hasWrapper function.
This should fix both commands after #3105

Let mw know,
cheers,
Simon

@arcanis

arcanis commented Apr 20, 2017

Copy link
Copy Markdown
Member

Oh, thanks. Curious Travis didn't catch that.

@arcanis
arcanis merged commit 219bd63 into yarnpkg:master Apr 20, 2017
@voxsim

voxsim commented Apr 20, 2017 •

Copy link
Copy Markdown
Contributor Author

@arcanis the main problem is that every command has tests that use directly the run function; instead this problem is in src/cli/index.js; they are kinda like integration tests. We can think to add a test for every command in __tests__/index.js as acceptance test that covers the whole path; What do you think? I think we didn't do that before to have fastest tests :P

This was referenced Apr 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants