Add tests for global command - #3238
Conversation
|
IMO we should remove reporter and install from |
|
@bestander if you don't have time to review this PR right now, I can open a mini PR that fixes for #3142. |
0d0f3ed to
2040243
Compare
|
@voxsim There's a test that fails on Windows, can you give it a look? |
|
I assume this also closes #2725? |
|
@arcanis ok I will look this tomorrow ;) @TimvdLippe yes it should close that pull request, but please check it, ok? |
|
@voxsim Sure, will do tomorrow 😄 |
…re side-effects free
…in folder inside, do assert only on global folders for yarn global v0.23.3 Done in 0.26s.
2040243 to
e66c593
Compare
|
@arcanis now should work ;) |
TimvdLippe
left a comment
There was a problem hiding this comment.
Can confirm it actually runs on my machine now, finally a green build! Not sure if isCI is the nicest solution, but at least it works for now. Could you add Closes #2725 to the pull request description?
|
@TimvdLippe done ;) |
|
@TimvdLippe I didn't delete that tests because I have no idea how to prove that tests are useful or not. For what I understand we can delete without worries. |
|
That's great, thanks! Let's merge it! :) |
This pull request adds:
yarn global lsdoes not list global packages #3142, Problems installing packages globally #3089 (?)cc @bestander @arcanis