Fix: Use a dedicated sink for tar reading instead of a transform stream - #3646
Merged
Merged
Conversation
**Summary** Potentially fixes #3011 (specifically https://git.io/vHAzW) Turns out our `ConcatStream` implementation was only used to read from `tar-fs` when creating a package to upload and put that stream into a memory buffer. Since `ConcatStream` was implemented as a `stream.Transform` and nothing was reading back from it, it had the potential to just hang there until something reads from it. This patch replaces that with [a small script][1]. [1]: http://www.geekpeak.de/images/produkte/i22/22-go-away-or-i-will-replace-you-de.jpg **Test plan** Removed existing tests for the old module. Rely on other existing tests for the replacement code.
bestander
approved these changes
Jun 16, 2017
bestander
left a comment
bestander
left a comment
Member
There was a problem hiding this comment.
Less code - good.
Merge once Circle is green
This was referenced Jun 22, 2017
Closed
|
@BYK hey, this issue is still happening. Do you have any plans to fix this? i am receiving 9.154668655 Request "https://registry.npmjs.org/xxxxxx" finished with status code 200. And gets stuck. yarn v 1.22.10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Potentially fixes #3011 (specifically https://git.io/vHAzW).
Turns out our
ConcatStreamimplementation was only used to readfrom
tar-fswhen creating a package to upload and put that streaminto a memory buffer. Since
ConcatStreamwas implemented as astream.Transformand nothing was reading back from it, it had thepotential to just hang there until something reads from it. This
patch replaces that with a small script.
Test plan
Removed existing tests for the old module. Rely on other existing
tests for the replacement code.